Repository navigation
improvement(sim-links): drop the leftover fragment around the source actions menu - #9661
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
…actions menu The new-link form moved to the provider root, so the source card's actions menu no longer renders a sibling and needs no fragment.
waleedlatif1
force-pushed
the
improvement/source-actions-fragment
branch
from
November 4, 2026 09:27
5445950 to
0b84d37
Compare
Contributor
 [Low impact] This PR appears safe to merge. SummaryRemoves the redundant fragment around
Reviews (1) · Last reviewed commit: "improvement(sim-links): drop the leftove..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SourceActionsstill wrapped its singleDropdownMenuin a fragment after the new-link form moved toSimLinkOrganizationProvider(fix(sim-links): open the new-link form above the sources popover and suggest hyphenated names #9654). This removes it; rendering is unchanged.Test plan
biome checkon the filemessage-sources.test.tsxdrives this menu end to end)