Repository navigation
Conversation
|
@heydryft is attempting to deploy a commit to the Sim Team on Vercel. A member of the Team first needs to authorize it. |
[Medium impact] The new request path is limited to workflows that choose Runcrate models. No behavioral blocker was found, but the new exports must satisfy the repository's TSDoc requirement before merging. Findings
SummaryAdds Runcrate as a bring-your-own-key provider for Agent blocks.
|
| return messages | ||
| } | ||
|
|
||
| export const runcrateProvider: ProviderConfig = { |
There was a problem hiding this comment.
New exports lack required docs
The new runcrateProvider and RuncrateIcon exports have no TSDoc, which CLAUDE.md requires for exported APIs. Add short comments describing their purpose, including the provider's key requirement and tool-choice fallback, so callers do not have to read the implementation. This repository requirement must be satisfied before merging.
Context Used: CLAUDE.md (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
Added TSDoc to runcrateProvider and RuncrateIcon, covering the API key requirement and the tool choice fallback. |
Thanks for building Sim: the shared openai-compat helper and the add-model skill made this a small, clean addition.
Summary
Adds Runcrate as a BYOK model provider for the Agent block. Runcrate is an AI cloud with an OpenAI-compatible inference API at
https://api.runcrate.ai/v1, so the new provider goes through the shared openai-compat chat-completions helper, the same way Nebius does.runcrate/<org>/<model>: DeepSeek V3.2, Gemma 3 27B, Llama 3.3 70B, MiniMax M3, Qwen3 235B, Qwen3 Coder 480B and GLM 5.3. Ids, context windows and per-million-token pricing were taken fromGET https://api.runcrate.ai/v1/models.tool_choiceon the others, so those fall back toauto, the same pattern Nebius uses.RuncrateIcon.agent.mdxandcosts.mdx.Product update (if relevant)
Workspaces can add their own Runcrate API key and use Runcrate-hosted open models in Agent blocks. On self-hosted Sim, the key goes in the Agent block's API Key field.
Type of Change
Testing
Run from
apps/simunless noted, afterbun install --ignore-scripts(theisolated-vmnative build failed on my machine, which does not affect these checks):bunx vitest run providers/runcrate providers/utils providers/models providers/attachments providers/history-adapters lib/api-key: 14 files, 359 tests passed (the 9 newproviders/runcrate/index.test.tstests: wire contract and auth header, case-insensitive model resolution, strict JSON schema, forced-tool downgrade for four models, SSE reasoning and usage with catalog pricing, missing key). The new Runcrate cases inlib/api-key/byok.test.tspass with the rest of that file.bun run type-check(inapps/sim): clean.bunx biome checkon the touched files: no findings.bun run check:byok-providers,check:icon-paths,check:bare-icons,check:file-namesandcheck:source-conventionspass.Reviewers may want to look at the per-model
forcedToolUseflags and the icon, which I drew as a simple SVG of the brand mark.Disclosure: I work on Runcrate.
This PR was prepared with AI assistance (omp with Claude): the code, tests, docs and this description were written with it, and the commands above were run as part of preparing it.
Checklist
Screenshots/Videos