Repository navigation
feat(wallpaper): add cached image effects pipeline - #33
Merged
mirkobrombin merged 1 commit intoOct 14, 2026
Merged
mirkobrombin merged 1 commit into
mirkobrombin merged 1 commit into
Conversation
perlowja
force-pushed
the
feat/wallpaper-effects-phase2-pr
branch
from
September 29, 2026 21:43
faa01fe to
f984922
Compare
Add grayscale, blur, oil-paint, and quote effects with a bounded cache, settings UI, schema fixture, and round-trip coverage. Assisted-by: Claude Code:claude-sonnet-5 Assisted-by: Codex:gpt-5.6-sol AI-Scope: Rebased Phase 2, resolved current wallpaper overlaps, added the settings contract fixture and round-trip test, and fixed test linkage.
mirkobrombin
force-pushed
the
feat/wallpaper-effects-phase2-pr
branch
from
October 14, 2026 10:54
f984922 to
c0440b8
Compare
Member
|
Aligned before merging. Kept grayscale and blur, dropped oil painting and the quote overlay. Both remaining effects are linear and already run in the loader thread, so the 500 MiB raw pixel cache isn't needed and is gone too. Rewrote the effects file in our normal formatting, one statement per line. Rebased on main. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #32. This branch is based on the current Phase 1 PR head and must be rebased onto
mainafter #32 merges.The shipped GSettings contract is in singularityos-lab/singularity-desktop#264; this PR must not merge before that schema change ships.
Adds native grayscale, blur, oil-paint, and quote-overlay transforms, a bounded 500 MiB cache, settings controls, and live reloads when effect settings change.
Verification:
wallpaper-effects-test: 6/6 passed, including all four transforms, cache hit, and a memory-backend set/read-back of all three UI keysglib-compile-schemas --strictpassed for the fixture and shipped schema PRAI assistance: disclosed