Repository navigation
shell: close the launcher popup before opening the workspace chooser - #35
Merged
mirkobrombin merged 2 commits intoOct 14, 2026
Conversation
toggle_workspace_overview() is the path the panel and dock use, and it never dismissed app_menu. The workspace chooser is a full-screen TOP-layer surface, so an open launcher popup was left visible underneath and occluded the menu that launched it. Assisted-by: opencode:deepseek-flash AI-Scope: inserted the app_menu dismissal ahead of ensure_workspace_overview() in toggle_workspace_overview().
Member
|
Right fix, same as hide_overview() already does. I dropped the comment and squashed with a fix: subject, shell: is not one of our commit types. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toggle_workspace_overview()is the path the panel and dock use, and it never dismissedapp_menu. The workspace chooser is a full-screen TOP-layer surface, so an open launcher popup was left visible underneath and occluded the menu that launched it. Dismissapp_menufirst, the same wayhide_overview()already does.Verified:
meson setup && meson compileclean andmeson test18/18 in adebian:forkycontainer. Confirmed against currentmain(3b72f26) thattoggle_workspace_overview()still lacks the dismissal.AI assistance: disclosed