Repository navigation
Upgrade framework and page middleware; version website assets - #88
Merged
Merged
Conversation
dblock
force-pushed
the
upgrade/rack-server-pages-0.3.0
branch
from
October 25, 2026 19:37
4096c05 to
a24c645
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dblock
force-pushed
the
upgrade/rack-server-pages-0.3.0
branch
from
October 25, 2026 21:03
a24c645 to
c189784
Compare
dblock
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade slack-ruby-bot-server to the released 2.3.0 and rack-server-pages to 0.3.0. Add explicit compatible dependency constraints; keep the dependency update narrowly scoped.
Version local CSS, JavaScript, image, favicon, and stylesheet background-image URLs through the escaped asset_path helper. Keep /styles.css as the public URL while rendering styles.css.erb so nested image URLs change when image content changes.
Configure template Cache-Control: private, no-cache centrally through config.server_pages in the framework initializer. Remove the per-template header assignments from the shared head partial and generated stylesheet. Preserve static-file ETag/timestamp defaults and the existing revalidation policy; versioned URLs are not immutable archives. Update website caching guidance and changelog.
Load application initializers before test support builds the Capybara middleware stack, matching production boot order. Adapt the health-error regression to stub the Slack API instead of the old unfiltered model-selection implementation, and cover 2.3.0 deactivation/explicit failed-ping behavior for revoked installations.
Validation
Full local suite: 72 examples, 0 failures, including browser refresh/background-image coverage, HTML/generated-CSS headers, content-versioned asset URLs, static ETag validation, and health-check errors. RuboCop auto-correction and baseline regeneration completed with no new exclusions or increased limits.
Authored by Copilot (AI), on behalf of @dblock.