Repository navigation
chore(release): remove the Solid Query gate; fix Windows tsrx runtime test - #3902
Conversation
… test path filter Co-authored-by: Cursor <cursoragent@cursor.com>
|
Size (brotli, eager entry chunk)
|
Coverage Report for CI Build 37712549703Coverage remained the same at 76.43%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Merging this PR will degrade performance by 13.54%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | memo + sync render effect only (reference) |
28 ms | 32.4 ms | -13.54% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing chore/remove-solid-query-gate (a287cbc) with next (e799cbd)
Summary
Two release-path fixes so
2.0.0-rc.14can publish:Remove the TanStack Solid Query gate from the release path. At the maintainer's request,
scripts/release.mjsno longer runstest:solid-querybefore publishing, and theSKIP_SOLID_QUERY_GATEvalve (and its comment inrelease.yml) is gone. The gate pulls TanStack's livesolid-query-v6-prebranch at publish time, so an upstream change can fail a release that is otherwise green. It has now blocked two releases: rc.12, and rc.14 (run 37711322663:tsc --buildof upstream failed withreadonly X[]vsX[]errors).packages/test-integrationand itstest:solid-queryscript stay so the check can still be run by hand; the spec's header comment now says so.Fix the Windows compiler-binaries test.
tsrx-runtime.test.js(added in fix(compiler): preserve TSRX expression and comment spans #3787 /c8aac88f9) uses an esbuildonLoadhook to appendexport * from "solid-js"topackages/universal/test/custom.js. Its filter was/\/universal\/test\/custom\.js$/, which only matches forward slashes; esbuild gives backslash paths on Windows, so the hook never ran there and the bundle failed withNo matching export in "../universal/test/custom.js" for import "For"/"Errored". The filter now accepts either separator. This has failed thex86_64-pc-windows-msvcjob on everynextpush since Oct 5, and would have skipped the platform-package publish in the release's dispatched binaries run.No
packages/*/srcchanges and no changeset: the rc.14 version commit is already onnext, so the next Release run publishes.Public API changes
None. Tooling and tests only.