Repository navigation
03-docs: render the deployment record without PyYAML - #4
Merged
Merged
Conversation
The build box has python3 but not PyYAML, and render-deployment-docs.sh imported yaml outside its try block to read the public origin from intent.yaml. The import fails with exit 1 and no message, so a console build stops at 03-docs with its site live. blog-starter, astro-boilerplate and portfolio-starter-kit hit this first (sourceplane/blog-starter#9); this ports the same fix. The hook uses PyYAML when present and otherwise reads environments.<env>.env.SITE_URL by indentation. testing/render.test.sh runs it under a python3 with no third-party packages, and Baseline CI runs that test. Records risk NG-H. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
hooks/render-deployment-docs.shimportsyamloutside itstryto read the public origin fromintent.yaml. The console build box haspython3but not PyYAML, so the hook exits 1 with no message and every console build stops at 03-docs with its site already live. blog-starter, astro-boilerplate and portfolio-starter-kit hit exactly this on 2026-11-06; a sweep of the registry found it here too. Same fix as sourceplane/blog-starter#9.hooks/render-deployment-docs.sh: uses PyYAML when present, otherwise readsenvironments.<env>.env.SITE_URLby indentation with the standard library only.testing/render.test.sh(new, in Baseline CI's contract tests): runs the hook under a python3 with no third-party packages and with the system one; both must render the record and read the origin the same way.Checked
ModuleNotFoundError: No module named 'yaml'.leakandplacementneed orun v2.88.0 and are left to CI.Not yet proven: a console build through 03-docs. That needs the next
baseline-vNtag on the merge and the registry bump in orun-cloud.🤖 Generated with Claude Code