Skip to content

03-docs: render the deployment record without PyYAML - #4

Merged
vijayakrishnans merged 1 commit into
mainfrom
claude/render-without-pyyaml
Nov 6, 2026
Merged

vijayakrishnans merged 1 commit into
mainfrom
claude/render-without-pyyaml

Conversation

@vijayakrishnans

Copy link
Copy Markdown
Contributor

What

hooks/render-deployment-docs.sh imports yaml outside its try to read the public origin from intent.yaml. The console build box has python3 but not PyYAML, so the hook exits 1 with no message and every console build stops at 03-docs with its site already live. blog-starter, astro-boilerplate and portfolio-starter-kit hit exactly this on 2026-11-06; a sweep of the registry found it here too. Same fix as sourceplane/blog-starter#9.

  • hooks/render-deployment-docs.sh: uses PyYAML when present, otherwise reads environments.<env>.env.SITE_URL by indentation with the standard library only.
  • testing/render.test.sh (new, in Baseline CI's contract tests): runs the hook under a python3 with no third-party packages and with the system one; both must render the record and read the origin the same way.
  • Records risk NG-H.

Checked

  • The new test passes; against the old hook it fails with ModuleNotFoundError: No module named 'yaml'.
  • All of Baseline CI's contract tests pass locally. leak and placement need orun v2.88.0 and are left to CI.

Not yet proven: a console build through 03-docs. That needs the next baseline-vN tag on the merge and the registry bump in orun-cloud.

🤖 Generated with Claude Code

The build box has python3 but not PyYAML, and render-deployment-docs.sh
imported yaml outside its try block to read the public origin from
intent.yaml. The import fails with exit 1 and no message, so a console build
stops at 03-docs with its site live. blog-starter, astro-boilerplate and
portfolio-starter-kit hit this first (sourceplane/blog-starter#9); this ports
the same fix.

The hook uses PyYAML when present and otherwise reads environments.<env>.env.SITE_URL
by indentation. testing/render.test.sh runs it under a python3 with no
third-party packages, and Baseline CI runs that test. Records risk NG-H.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-06T13:16:32.191071Z 3318677 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@vijayakrishnans
vijayakrishnans merged commit a200047 into main Nov 6, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant