Skip to content

The web smoke asserts with here-strings, not a pipe into grep -q - #6

Merged
vijayakrishnans merged 1 commit into
mainfrom
claude/smoke-no-pipe
Nov 13, 2026
Merged

vijayakrishnans merged 1 commit into
mainfrom
claude/smoke-no-pipe

Conversation

@vijayakrishnans

Copy link
Copy Markdown
Contributor

Why

A product built from this baseline today (vijayakrishnans/screwfast-site-and-docs-2) deployed fine, but smoke failed 10 of 10 attempts on stage and prod, and failed again on the rerun. Both sites served correctly the whole time.

The smoke step runs under set -o pipefail. echo "${html}" | grep -q 'hreflang="fr"' on the 126 KB home page fails every time: grep -q exits at its first match, echo dies of SIGPIPE (141), and pipefail fails the check.

What

  • apps/web/component.yaml: the three assertions read here-strings (grep -q 'x' <<< "${html}"), so nothing is piped.
  • apps/web/docs/runbook.md: the copy of the command matches.
  • testing/placement.test.sh: fails if the smoke command pipes into grep -q.

Verified

The new command under set -uo pipefail passes against the live stage and prod sites of screwfast-site-and-docs-2. The old one exits 141.

The platform-side guard is sourceplane/stack-tectonic#24. This fix works with or without it. A new baseline-v4 tag and registry row are needed before new builds pick this up.

🤖 Generated with Claude Code

The smoke step runs under pipefail. `echo "${html}" | grep -q` on the home
page (126 KB as built) fails with SIGPIPE (141) as soon as grep finds its
match, so a product built from this baseline failed smoke 10 of 10 times on
stage and prod while both sites served correctly (screwfast-site-and-docs-2,
2026-11-13). The three assertions now read here-strings, the runbook copy
matches, and the placement test refuses a smoke that pipes into grep -q.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T07:46:31.031264Z 0c88f08 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@vijayakrishnans
vijayakrishnans merged commit a29ea9a into main Nov 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant