Repository navigation
The web smoke asserts with here-strings, not a pipe into grep -q - #6
Merged
Merged
Conversation
The smoke step runs under pipefail. `echo "${html}" | grep -q` on the home
page (126 KB as built) fails with SIGPIPE (141) as soon as grep finds its
match, so a product built from this baseline failed smoke 10 of 10 times on
stage and prod while both sites served correctly (screwfast-site-and-docs-2,
2026-11-13). The three assertions now read here-strings, the runbook copy
matches, and the placement test refuses a smoke that pipes into grep -q.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A product built from this baseline today (
vijayakrishnans/screwfast-site-and-docs-2) deployed fine, butsmokefailed 10 of 10 attempts on stage and prod, and failed again on the rerun. Both sites served correctly the whole time.The smoke step runs under
set -o pipefail.echo "${html}" | grep -q 'hreflang="fr"'on the 126 KB home page fails every time:grep -qexits at its first match,echodies of SIGPIPE (141), and pipefail fails the check.What
apps/web/component.yaml: the three assertions read here-strings (grep -q 'x' <<< "${html}"), so nothing is piped.apps/web/docs/runbook.md: the copy of the command matches.testing/placement.test.sh: fails if the smoke command pipes intogrep -q.Verified
The new command under
set -uo pipefailpasses against the live stage and prod sites of screwfast-site-and-docs-2. The old one exits 141.The platform-side guard is sourceplane/stack-tectonic#24. This fix works with or without it. A new
baseline-v4tag and registry row are needed before new builds pick this up.🤖 Generated with Claude Code