Repository navigation
Use the midpoint for unsigned 8-bit playback silence - #645
Merged
Merged
Conversation
The convenience playback callback fills unused channels and the final partial block with silence. Use 128 for uint8 PCM, matching the PortAudio sample format, and retain zero for signed and floating formats. Cover final padding, channel mapping and looped playback.
Member
|
Thanks for this PR! Similar to #644, this adds both a new feature and a new testing framework. Those should be two separate discussions. |
Contributor
Author
|
Thanks. I removed the standalone unittest file in 87708d0. The PR now changes only the two silence fills; testing infrastructure can be discussed separately. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The convenience playback callback fills unmapped channels and the final partial block with zero. For
uint8, zero is the negative endpoint; silence is 128, as documented by SoundDevice and PortAudio. This can send a DC signal on a channel intended to be silent.Choose the fill value from the output dtype and use it at both sites.
Validation: