Repository navigation
refactor(cli): drop vars that only kept imports alive - #61
Merged
Merged
Conversation
exec.go held `var _ = json.Marshal` and `var _ = strings.Join` to keep imports in use; json had no other use, so its import goes too. TestE2E_BuildUpExec_Image built an exec.Cmd it never ran. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dead code found during the comment cleanup (#59):
internal/cli/exec.go:var _ = json.Marshalandvar _ = strings.Joinexisted only to keep imports in use.encoding/jsonhad no other use, so its import is gone too;stringsis still used.internal/cli/e2e_test.go:TestE2E_BuildUpExec_Imagebuilt anexec.Cmdit never ran (_ = cmd).No behavior change, so there's no new test:
go build,go vet(with and without thee2etag) andtask lint(deadcode included) pass.🤖 Generated with Claude Code