Skip to content

fix(bigquery): support escaped quotes in raw and bytes strings #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaxFreedomPollard wants to merge 1 commit into from
Closed

fix(bigquery): support escaped quotes in raw and bytes strings #1002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/languages/bigquery/bigquery.formatter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,10 +179,8 @@ export const bigquery: DialectOptions = {
// Otherwise the first two quotes of """ will get matched as an empty "" string.
{ quote: '""".."""', prefixes: ['R', 'B', 'RB', 'BR'] },
{ quote: "'''..'''", prefixes: ['R', 'B', 'RB', 'BR'] },
'""-bs',
"''-bs",
{ quote: '""-raw', prefixes: ['R', 'B', 'RB', 'BR'], requirePrefix: true },
{ quote: "''-raw", prefixes: ['R', 'B', 'RB', 'BR'], requirePrefix: true },
{ quote: '""-bs', prefixes: ['R', 'B', 'RB', 'BR'] },
{ quote: "''-bs", prefixes: ['R', 'B', 'RB', 'BR'] },
],
identTypes: ['``'],
identChars: { dashes: true },
Expand Down
15 changes: 14 additions & 1 deletion test/bigquery.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ describe('BigQueryFormatter', () => {
supportsUpdate(format);
supportsTruncateTable(format);
supportsMergeInto(format);
supportsStrings(format, ['""-bs', "''-bs", "R''", 'R""', "B''", 'B""']);
supportsStrings(format, ['""-bs', "''-bs", "B''", 'B""']);
supportsIdentifiers(format, ['``']);
supportsArrayLiterals(format, { withArrayPrefix: true, withoutArrayPrefix: true });
supportsBetween(format);
Expand Down Expand Up @@ -166,6 +166,19 @@ describe('BigQueryFormatter', () => {
`);
});

// Issue #762
it('supports escaped quotes in strings with r, b and rb prefixes', () => {
expect(format(`SELECT r'a\\'b', R"c\\"d", b'e\\'f', rb"g\\"h" FROM foo`)).toBe(dedent`
SELECT
r'a\\'b',
R"c\\"d",
b'e\\'f',
rb"g\\"h"
FROM
foo
`);
});

it('supports STRUCT types', () => {
const result = format('SELECT STRUCT("Alpha" as name, [23.4, 26.3, 26.4] as splits) FROM beta');
expect(result).toBe(dedent`
Expand Down
Loading