Repository navigation
Accept schema-qualified operator names in CREATE / DROP OPERATOR - #999
Closed
zzoraemon043 wants to merge 1 commit into
Closed
zzoraemon043 wants to merge 1 commit into
zzoraemon043 wants to merge 1 commit into
Conversation
Collaborator
|
I'm adopting a new policy for this repository: no AI-generated contributions. I don't care how good they are. This is to preserve my sanity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #997
CREATE OPERATOR pg_catalog.!! (...)failed withUnexpected OPERATOR token, becauseproperty_accessonly accepts an identifier after the dot.DROP OPERATOR pg_catalog.!! (...)failed the same way.The tokenizer now turns an operator token into an identifier when it comes right after a property access operator and right before an opening paren. That covers the operator name in CREATE / ALTER / DROP OPERATOR, which is always followed by its argument list, while
SELECT foo.+;still raises the parse error that the existing test expects.Operators that the PostgreSQL tokenizer does not know as a single token, such as
===, are still split into separate tokens, sopublic.===is not covered here.