Skip to content

feat: Write file logs to an emptyDir - #766

Merged
lfrancke merged 2 commits into
mainfrom
feat/file-log-volume
Oct 27, 2026
Merged

lfrancke merged 2 commits into
mainfrom
feat/file-log-volume

Conversation

@lfrancke

Copy link
Copy Markdown
Member

Description

Part of stackabletech/issues#903

stackabletech/operator-templating#656 moved file logs to /var/log/<operator> on an emptyDir, but secret-operator doesn't use the templated Deployment. Great.
This now adds the missing volume.

Tested on k3d (Kubernetes 1.33.9) with the 0.0.0-dev image and file logs on: both pods run, the controller with a read-only root filesystem, and both write their logs into the volume.

Definition of Done Checklist

Author

  • Changes are OpenShift compatible
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)

Reviewer

  • Code contains useful comments
  • Changelog updated

Acceptance

  • Proper release label has been added
  • Release note snippet added

@lfrancke lfrancke self-assigned this Oct 22, 2026
@lfrancke lfrancke moved this to Development: Waiting for Review in Stackable Engineering Oct 22, 2026
@razvan
razvan self-requested a review October 27, 2026 13:18
@razvan razvan moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 27, 2026

@razvan razvan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lfrancke
lfrancke added this pull request to the merge queue Oct 27, 2026
@lfrancke lfrancke moved this from Development: In Review to Development: Done in Stackable Engineering Oct 27, 2026
Merged via the queue into main with commit d6120d7 Oct 27, 2026
13 checks passed
@lfrancke
lfrancke deleted the feat/file-log-volume branch October 27, 2026 14:10
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

2 participants