Repository navigation
fix: Keep S3 credentials out of container logs - #796
Merged
Merged
Conversation
razvan
self-requested a review
October 23, 2026 15:37
razvan
approved these changes
Oct 23, 2026
razvan
left a comment
Member
There was a problem hiding this comment.
Not sure if you know but spark-submit still has --verbose. A user that changes spark.redaction.regex to a nonsense value like stacky could still see S3 secrets (and any other secrets).
still, it lgtm!
Member
Author
|
Okay, I wasn't aware but... I think if people change that then.....they are on their own. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See title. Currently the output of the container logs can contain secrets.
This fixes that.
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker