Repository navigation
Conversation
dtext
force-pushed
the
main
branch
3 times, most recently
from
October 20, 2026 09:20
df6d413 to
fb38288
Compare
dtext
marked this pull request as ready for review
October 20, 2026 12:27
joaoferrao
reviewed
Oct 20, 2026
joaoferrao
reviewed
Oct 20, 2026
Comment on lines
+79
to
+80
| Acl: types.ListValueMust(types.StringType, []attr.Value{types.StringValue("0.0.0.0/0")}), | ||
|
|
There was a problem hiding this comment.
Since we claim to support ipv6, should we also add a test for that?
Author
There was a problem hiding this comment.
I'd argue probably not here because they're just strings as well. The only thing preventing this from being compatible with ipv6 would be if validate.CIDR() didn't pass for IPv6 CIDRs, but they're just using net.ParseCIDR() which documents IPv6 compatibility.
Fyusel
requested changes
Oct 21, 2026
Fyusel
left a comment
Fyusel
left a comment
Contributor
There was a problem hiding this comment.
Some feedback right now, still in progress
dtext
force-pushed
the
main
branch
5 times, most recently
from
October 28, 2026 07:58
bf55408 to
a82f2f3
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)