Repository navigation
Conversation
| accessToken, err := getAccessToken(e.roundTripper) | ||
| if err != nil { | ||
| core.LogAndAddError(ctx, &resp.Diagnostics, "Access token generation failed", err.Error()) | ||
|
|
Contributor
There was a problem hiding this comment.
is this configurable?
Contributor
Author
There was a problem hiding this comment.
Yes, I changed the linter to the default configuration and configured that 4 lines are allowed to cuddle before a whitespace is needed.
Comment on lines
355
to
359
| resp.Diagnostics.Append(req.Config.Get(ctx, &configModel)...) | ||
|
|
||
| if resp.Diagnostics.HasError() { | ||
| return | ||
| } |
Contributor
There was a problem hiding this comment.
is this configurable? AFAIK there's another linter that prevents
if resp.Diagnostics.Append(req.Config.Get(ctx, &configModel)...); resp.Diagnostics.HasError() {
return
}
IMO this statement and the if belong together
Contributor
Author
There was a problem hiding this comment.
this isn't configurable. If the statement resp.Diagnostics.Append(req.Config.Get(ctx, &configModel)...) would return a value which is consumed by the if condition, then it would be allowed to keep them together. But I also think that they should remain together so I added an exclusion for this specific case
marceljk
force-pushed
the
chore/add-whitespace-linter
branch
from
October 21, 2026 14:20
702b0fd to
442bb36
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to #1234
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)