Repository navigation
Test the glmer() refits without projpred's own Laplace fit - #659
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests in
test_fitter_retries.R(#633) mocklme4::glmer()to give fit errors, and check the refits offit_glmer_callback(). Most of them use binomial submodels whose group-level terms are all(1 | <group>). Since #644,fit_glmer_callback()fits these submodels with projpred's own Laplace fit, so it does not call the mock. On master, all six R CMD check jobs fail with the same 15 failures intest_fitter_retries.R(run https://github.com/stan-dev/projpred/actions/runs/44304319966 on 1d983fe, the merge of #644). #645 inherits these failures from master. The macOS job also has failures intest_loo_fold_projection.Randtest_methods_vsel.R, which this PR does not change.This PR passes
mlvl_laplace = FALSEin the test helperfit_glmer_retry(), so the tests uselme4::glmer()again. Only the test file changes.Tests: on ad65ce7,
test_fitter_retries.Rwithsetup.RandNOT_CRAN=truegives 66 expectations, 0 failures and 0 warnings (R 4.6.1, testthat 3.3.2, lme4 2.0.6).This PR was assisted by Claude