Repository navigation
Conversation
Migrate the test suite from relative tolerance assertions to ULP difference assertions. The `isApprox` test helper now delegates to `@stdlib/assert/is-almost-same-value`, and each call site specifies the minimum ULP bound required to pass. Every compared element is bit-exact against the fixtures, so the measured minimum is zero ULP for all call sites in both files. Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WbopwtTe2hqYuudNtoJxSS --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
blas/base/dsymvfrom relative tolerance assertions to ULP difference assertions.The shared
isApproxtest helper previously computedrtol * EPS * abs( expected )and asserted witht.ok( delta <= tol, ... ). It now delegates to@stdlib/assert/is-almost-same-value:Each call site now declares a local
ULPbound in place of the previous blanket2.0relative tolerance.Final ULP constant:
0at every call site.test/test.dsymv.jstest/test.ndarray.jsNotes on how the bounds were measured:
isApproxto compute, per call site, the maximum@stdlib/number/float64/base/ulp-differenceover every compared element. The measured maximum was 0 for all 20 call sites, i.e., the computed output is bit-identical to the fixture values for every element in both the main andndarraytest files. The previous2.0 * EPSrelative tolerance was therefore never exercised.0is the floor for a nonnegative ULP bound, so minimality is exact rather than approximate. Note thatisAlmostSameValue( a, b, 0 )reduces toisSameValue( a, b ); the probe additionally confirmedisSameValueholds for every compared element, so signed-zero handling is unaffected.test.native.jsvariants, so there is no JS/C divergence to account for.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
One, flagged for explicit review:
test/test.dsymv.jscarried a pre-existingstdlib/no-empty-lines-between-requireslint error on the blank line separating the row-major and column-major fixturerequires (line 41 ondevelop). Since the pre-commit hook lints changed test files withFIX=1, that blank line is auto-removed, and this PR therefore includes that one-line whitespace fix. It is unrelated to the ULP migration and can be dropped if you would rather keep the visual grouping and address the lint error separately. (Curiously,test/test.ndarray.jshas a byte-identical fixture block but is not flagged by the rule.)Other
Because
dsymvis exercised only through its JavaScript implementation here, the bit-exactness above is IEEE-754 reproducible and not subject to FMA-contraction differences across architectures.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code. It studied the already-converted packages in the same family (notably
blas/base/drotandblas/base/dzasum) to match the establishedisApprox/ULPidiom, then measured the minimum ULP bound for each call site empirically and verified determinism as described above.@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01WbopwtTe2hqYuudNtoJxSS
Generated by Claude Code