Skip to content

ci: reuse CI workflow for releases - #46

Open
usercao wants to merge 2 commits into
mainfrom
ci/reuse-ci-workflow-for-release
Open

usercao wants to merge 2 commits into
mainfrom
ci/reuse-ci-workflow-for-release

Conversation

@usercao

@usercao usercao commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

Make the continuous integration workflow callable and have the release workflow use it as the shared verify job.

The release and prerelease jobs now wait for the same full gate as pull requests and pushes to main, including:

  • formatting, linting, type checking, unit tests, and the scaling guardrail;
  • package build, API consumer, runtime, and contents checks;
  • the supported TypeScript e2e matrix;
  • the Node 14.21.3 package-floor tsserver smoke test;
  • graceful non-activation on unsupported TypeScript 4.9.5.

The CI concurrency key includes the calling workflow name so a release run and a normal CI run for the same ref do not cancel each other. The maintenance documentation records the reusable workflow relationship.

Testing

  • corepack yarn oxfmt --check .github/workflows/ci.yml .github/workflows/release.yml docs/maintenance.md

The reusable workflow call and release dependency chain require GitHub Actions to validate end to end.

Copilot AI balanced review requested due to automatic review settings October 30, 2026 03:29
@changeset-bot

changeset-bot Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: b321d16

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Only formatting validation is reported, leaving the reusable CI gate, nested workflow invocation, artifact handoff, and publishing dependency chain unverified end to end in GitHub Actions.

No open issues 🎉

What changed in this PR

This PR reuses the full CI workflow as the release verification gate, keeping release checks aligned with pull request and push checks.

Changes:

  • Makes CI callable and separates concurrency groups for normal CI and release-triggered runs.
  • Replaces the release workflow’s standalone verification steps with the shared CI workflow.
  • Documents that release and prerelease jobs wait for the full CI gate.
File Description
docs/​maintenance.md Documents the shared verification gate and release dependencies.
.github/​workflows/​release.yml Calls CI as the reusable verify job.
.github/​workflows/​ci.yml Adds workflow_call and updates the concurrency key.

Review effort: Balanced

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No functional issues found — one maintainability suggestion inline.

Reviewed changes

  • ci.yml becomes reusable: adds the workflow_call trigger and prefixes the workflow-level concurrency group with ci-.
  • release.yml reuses the gate: the verify job drops its inline yarn verify steps and calls ./.github/workflows/ci.yml; release and prerelease still needs: verify.
  • Docs updated: docs/maintenance.md records that the release verify job runs the CI workflow, including the e2e matrix and smoke jobs.

Pullfrog  | Fix all ➔ | Fix 👍s ➔ | View workflow run | Using big-pickle (free) | 𝕏

Comment thread .github/workflows/ci.yml Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants