Repository navigation
chore: additional path quailification - #2592
Open
staaldraad wants to merge 8 commits into
Open
staaldraad wants to merge 8 commits into
staaldraad wants to merge 8 commits into
Conversation
Fully qualify all paths before a search_path switch. Standardise the way of doing this across all scripts.
Package version diffCompares built package versions in legacyPackages between this PR and the tip of the base branch, per system. aarch64-linux: Closure size: 73 -> 73 (2 paths added, 2 paths removed, delta +0, disk usage +176B).x86_64-linux: Closure size: 74 -> 74 (2 paths added, 2 paths removed, delta +0, disk usage +176B). |
staaldraad
changed the title
brainrake
previously requested changes
Oct 23, 2026
Collaborator
There was a problem hiding this comment.
May also need migrations.
20250218031949_pgsodium_mask_role.sqlstill createsmask_rolewithSET search_path TO ''.create extension pgsodiumgetspg_catalog, pg_tempfromafter-create.sql, while projects migrated through that file keep''.- similar for
pgmqwith the requested changes
Two small new migrations with the same mask_role/drop_queue definitions would remove the drift.
pinaraf
previously requested changes
Oct 23, 2026
pinaraf
left a comment
pinaraf
left a comment
Contributor
There was a problem hiding this comment.
The last flag of set_config, "local", makes it pointless to manually restore the search_path. So this can be greatly simplified...
Other than that, specifying a full path everywhere is the way to go...
Contributor
Wrong: I was not aware these files are included in others, making this comment moot. |
pinaraf
self-requested a review
October 23, 2026 14:33
PostgreSQL Extension Dependency Analysis: PR #2592
SummaryNo extensions had dependencies with MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Extension DependenciesExtension: pg_graphql
Raw Dependency TreeExtension: supabase_vault
Raw Dependency TreePostgreSQL 17 Extension DependenciesExtension: pg_graphql
Raw Dependency TreeExtension: supabase_vault
Raw Dependency TreeOrioleDB 17 Extension Dependencies |
PostgreSQL Package Dependency Analysis: PR #2592
SummaryNo packages had MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Dependency ChangesExtracting PostgreSQL 15 dependencies...
Runtime Closure Size
Raw Dependency ClosurePostgreSQL 17 Dependency ChangesExtracting PostgreSQL 17 dependencies...
Runtime Closure Size
Raw Dependency Closure |
staaldraad
dismissed
brainrake’s stale review
October 26, 2026 08:37
applied suggested changes and some further improvements
brainrake
previously requested changes
Oct 26, 2026
…er-create.sql Co-authored-by: Márton Boros <martonboros@gmail.com>
This comment has been minimized.
This comment has been minimized.
brainrake
previously requested changes
Nov 2, 2026
Co-authored-by: Márton Boros <martonboros@gmail.com>
Co-authored-by: Márton Boros <martonboros@gmail.com>
staaldraad
dismissed
brainrake’s stale review
November 2, 2026 17:52
great catch! can't believe I overlooked those, thank you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fully qualify all paths before a search_path switch.
Standardise the way of doing this across all scripts.