Repository navigation
fix: show insufficient funds when no hardware wallet covers a scan #1790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
363bf6c
fix: show insufficient funds when no hardware wallet covers a scan
jvsena42 ace05c4
docs: add journey for a scan over hardware spendable
jvsena42 3118c17
chore: add changelog fragment for the scan fix
jvsena42 cacd64a
Merge remote-tracking branch 'origin/master' into fix/scan-unaffordab…
jvsena42 8e1618e
docs: list the hardware scan journey as not ported to ios
jvsena42 2ee3d43
Merge remote-tracking branch 'origin/master' into fix/scan-unaffordab…
jvsena42 2ee82c2
test: fail the exact compose in the unaffordable scan test
jvsena42 6f5ee70
docs: note the ios port of the over-spendable scan journey
jvsena42 6d644d3
test: attempt the exact hardware compose in the over-spendable scan test
jvsena42 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Show an insufficient funds message when a scanned Bitcoin request is more than a hardware wallet can pay after fees, instead of opening an amount screen that cannot continue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
journeys/hardware-wallet/scan-onchain-amount-over-spendable.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| <journey name="scan onchain amount over hardware spendable"> | ||
| <description> | ||
| Verifies that an on-chain BIP21 request whose amount a paired hardware wallet's balance covers, | ||
| but not once the network fee is taken, shows the Insufficient Savings toast instead of opening | ||
| the Send Amount screen with a fixed amount that cannot be changed or continued. Nothing is | ||
| broadcast. | ||
| Precondition: an onboarded dev wallet with 0 sats in Savings and a paired Bridge emulator (see | ||
| README.md) whose native-segwit account holds a confirmed regtest balance B of at least 10 000 | ||
| sats, read from its home tile. Use an amount between B minus 100 sats and B, which the balance | ||
| covers but the balance minus any non-zero fee does not, and a regtest address the wallet does | ||
| not own. Start on the wallet home screen. | ||
| The Send Amount screen is identified by its number field (testTag "SendNumberField"), the | ||
| Confirm screen by its amount (testTag "ReviewAmount"). | ||
| </description> | ||
| <actions> | ||
| <action>Read the paired Trezor's balance B from its home tile and pick an amount A with B - 100 < A < B, written in BTC</action> | ||
| <action>Run adb shell am start -a android.intent.action.VIEW -d "bitcoin:<regtest address>?amount=<A>" to.bitkit.dev</action> | ||
| <action>Verify the Insufficient Savings toast (testTag "InsufficientSavingsToast") appears (screenshot), and neither the Send Amount screen (testTag "SendNumberField") nor the Confirm screen (testTag "ReviewAmount") opens</action> | ||
| <action>Pick an amount below B by at least 2 000 sats and run the same deep link with it</action> | ||
| <action>Verify the Confirm screen opens with the Trezor as the funding source and the amount shown (testTag "ReviewAmount"); close the sheet without sending</action> | ||
| </actions> | ||
| </journey> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.