Skip to content

feat(run-task): derive base_rev from the GitHub compare API - #1106

Merged
ahal merged 1 commit into
mainfrom
ahal/nnlqqxxqvwow
Nov 12, 2026
Merged

ahal merged 1 commit into
mainfrom
ahal/nnlqqxxqvwow

Conversation

@ahal

@ahal ahal commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.41%. Comparing base (785504a) to head (69e65b3).

Additional details and impacted files
@@                  Coverage Diff                  @@
##           ahal/kommvppkwoou    #1106      +/-   ##
=====================================================
+ Coverage              80.13%   80.41%   +0.27%     
=====================================================
  Files                    134      134              
  Lines                  14288    14424     +136     
  Branches                1654     1670      +16     
=====================================================
+ Hits                   11450    11599     +149     
+ Misses                  2399     2389      -10     
+ Partials                 439      436       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ahal
ahal force-pushed the ahal/nnlqqxxqvwow branch from 44d5a56 to 69e65b3 Compare November 12, 2026 16:28
@ahal

ahal commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

You can see this working here:
https://firefox-ci-tc.services.mozilla.com/tasks/GDWxO4BKRPq8nN4IsyqpBA/runs/0/logs/live/public%2Flogs%2Flive.log#L76-77

That graph was a force-push, so the passed in base_rev was referring to the old revision prior to the force push. But, run-task called compare API using github-repo-token, found the actual base rev and re-wrote it.

@ahal
ahal marked this pull request as ready for review November 12, 2026 21:41
@ahal
ahal requested a review from a team as a code owner November 12, 2026 21:41
@ahal
ahal requested a review from jcristau November 12, 2026 21:41

@hneiva hneiva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from ahal/kommvppkwoou to main November 12, 2026 22:14
@ahal
ahal force-pushed the ahal/nnlqqxxqvwow branch from 69e65b3 to 79d837c Compare November 12, 2026 22:14
@ahal
ahal enabled stacked auto-merge (rebase) November 12, 2026 22:14
@ahal
ahal merged commit 36ced14 into main Nov 12, 2026
22 of 23 checks passed
@ahal
ahal deleted the ahal/nnlqqxxqvwow branch November 12, 2026 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants