Repository navigation
Conversation
lgirdwood
commented
Nov 10, 2026
lgirdwood
left a comment
lgirdwood
left a comment
Member
Author
There was a problem hiding this comment.
pls check commit messages have correct line wrapping.
Enable rx_slots=3 alongside tx_slots=3 on the 48 kHz 2-channel SSP2-BT hardware configuration (hw_config.3) so full-duplex 48 kHz Bluetooth SSP offload streams can capture and play back simultaneously. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
lgirdwood
force-pushed
the
topic/sof-bt-offload
branch
from
November 11, 2026 12:48
562969f to
84e9247
Compare
lgirdwood
changed the title
Member
Author
|
@naveen-manohar fyi |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
BT capture reuses scheduler indexes assigned to DMIC and SoundWire jack capture paths, leaving critical collisions in the HDA and ACE3 topology targets.
2 open issues
What changed in this PR
This PR adds full-duplex SSP2 Bluetooth hardware-offload variants to existing HDA and RT722 SoundWire topologies, and enables the LP-GPDMA FIFO partitioning needed for ACE 1.5 streaming.
Changes:
- Adds optional Bluetooth support to the generic HDA topology and dedicated HDA and PTL/WCL RT722 BT targets.
- Enables receive slots for the 48 kHz stereo Bluetooth SSP configuration.
- Enables DMA FIFO partitioning on ACE 1.5 MTPM.
| File | Description |
|---|---|
tools/topology/topology2/sof-hda-generic.conf |
Adds SSP classes and conditional Bluetooth topology inclusion. |
tools/topology/topology2/production/tplg-targets-hda-generic.cmake |
Registers HDA Bluetooth targets, including DMIC variants. |
tools/topology/topology2/production/tplg-targets-ace3.cmake |
Adds the PTL RT722 Bluetooth target and WCL alias. |
tools/topology/topology2/platform/intel/bt-ssp-config.conf |
Enables receive slots for full-duplex 48 kHz operation. |
app/boards/intel_adsp_ace15_mtpm.conf |
Enables LP-GPDMA FIFO partitioning. |
Review effort: Balanced
Include SSP and Bluetooth offload definitions in sof-hda-generic.conf when ADD_BT=true without altering existing non-BT topologies. Add dedicated SSP2-BT offload topology targets (BT_PCM_ID=20, BT_PCM_NAME=Bluetooth, ADD_BT=true) for ACE 1.5/2.0 and ACE 3.0 HDA platforms (sof-hda-generic-ace1-bt, sof-hda-generic-ace3-bt, sof-hda-generic-ace3-2ch-bt, sof-hda-generic-ace3-4ch-bt) as well as ACE 3.0 / Wildcat Lake RT722 4ch SoundWire platforms (sof-ptl-rt722-4ch-bt and sof-wcl-rt722-4ch-bt). Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Enable CONFIG_DMA_DW_FIFO_PARTITION=y on ACE 1.5 (MTL/ARL-S) matching CAVS 2.5 so dw_dma_setup() partitions the LP-GPDMA hardware FIFO instead of leaving FIFO partition sizes at zero, preventing immediate SSP2-BT GATEWAY_UNDERRUN_DETECTED errors. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
lgirdwood
force-pushed
the
topic/sof-bt-offload
branch
from
November 13, 2026 17:40
84e9247 to
0f0ed9a
Compare
Member
Author
|
Addressed all review comments:
|
lgirdwood
marked this pull request as ready for review
November 13, 2026 20:47
lgirdwood
requested review from
dbaluta,
jsarha,
kv2019i,
lbetlej,
mmaka1,
plbossart and
ranj063
as code owners
November 13, 2026 20:47
PR 11432: test resultsRun date: 2026-11-13 21:24 UTC Tested commit: 0f0ed9acdaed8bd6d1f08ae3f469de9d002f56f1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This series enables full-duplex Bluetooth SSP (
SSP2-BT) hardware audio offload topologies (without altering existing non-BT topologies) and fixes ACE 1.5 LP-GPDMA FIFO partitioning required forSSP2-BTstreaming on Arrow Lake / Meteor Lake:topology2: bt-ssp-config: enable rx_slots on 48 kHz hw_config.3(e881e3ceb):rx_slots = 3alongsidetx_slots = 3onhw_config.3(48 kHz 2-channel TDM) so full-duplex 48 kHz Bluetooth SSP offload streams can capture and play back simultaneously.topology2: hda-generic, ace3: add SSP2-BT offload topologies(f547745ac):<ssp.conf>,<intel/hw_config_cardinal_clk.conf>,<bt-default.conf>, and conditionalplatform/intel/bt-generic.conf(ADD_BT=true) insof-hda-generic.confwithout modifying existing non-BT topologies.SSP2-BT(BT_PCM_ID=20, BT_PCM_NAME=Bluetooth, ADD_BT=true, using non-colliding pipeline scheduler IDsBT_PB_HOST_PIPELINE_ID=200, BT_PB_DAI_PIPELINE_ID=201, BT_CP_HOST_PIPELINE_ID=202, BT_CP_DAI_PIPELINE_ID=203) topology targets for ACE 1.5/2.0 and ACE 3.0 HDA platforms (sof-hda-generic-ace1-bt,sof-hda-generic-ace3-bt,sof-hda-generic-ace3-2ch-bt,sof-hda-generic-ace3-4ch-bt) and ACE 3.0 / Wildcat Lake RT722 4ch SoundWire platforms (sof-ptl-rt722-4ch-bt,sof-wcl-rt722-4ch-bt).app/boards: ace15_mtpm: enable CONFIG_DMA_DW_FIFO_PARTITION(0f0ed9acd):CONFIG_DMA_DW_FIFO_PARTITION=yinapp/boards/intel_adsp_ace15_mtpm.conf(matchingintel_adsp_cavs25.conf) sodw_dma_setup()partitions the LP-GPDMA hardware FIFO (0x16807f) instead of leaving FIFO partition sizes at zero, preventing immediateSSP2-BTGATEWAY_UNDERRUN_DETECTEDerrors on ACE 1.5 (mtl/arl-s).Hardware Validation (Over-the-Air DSP-to-DSP
SSP2-BThw:0,20)Validated bi-directionally (
500 HzTX on Wildcat Lakeladybird↔1000 HzTX on Panther Lakedamsel-flyand Arrow Lakedragon-fly) paired withthesofproject/linux#6031:ladybirdRX FFT (1000 HzTX)damsel-flyRX FFT (500 HzTX)SBC (0x00)(48 kHz 2ch)999.97 Hz(RMS 14119.6)499.35 Hz(RMS 14135.0)AAC (0x02)(48 kHz 2ch)1000.08 Hz(RMS 13707.5)500.57 Hz(RMS 13727.3)mSBC (0x05)(16 kHz 1ch)999.90 Hz(RMS 14142.7)500.08 Hz(RMS 14123.5)CVSD (0x02)(8 kHz 1ch)1000.14 Hz(RMS 10833.2)499.37 Hz(RMS 13668.5)G.711 u-law (0x00)(8 kHz 1ch)1000.00 Hz(RMS 14006.2)499.86 Hz(RMS 14177.9)G.711 A-law (0x01)(8 kHz 1ch)1000.29 Hz(RMS 14098.8)500.57 Hz(RMS 14261.1)Transparent (0x03)Raw PCM (8 kHz 1ch)999.77 Hz(RMS 14227.0)499.86 Hz(RMS 14194.3)Controller LC3 (0x06)(16 kHz 1ch)1000.03 Hz(RMS 15343.7)499.89 Hz(RMS 15503.1)