Repository navigation
Order the chained builder calls by name length and link the license badge to the repository. - #32
Merged
Conversation
…cense badge to the repository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four chains in
MySQLDockerContainerTestand the full configuration example of the README called the builders out of the order the code style asks for, which is method name length ascending with an alphabetical tiebreak. The license badge of the README also linked toLICENSEas a relative path, while the other tiny-blocks libraries link to the file on GitHub.What changes
MySQLDockerContainerTestorders the chains of the full configuration, the copy to the container, the single granted host and the granted hosts without a database. Only the order changes, the arguments stay the same.https://github.com/tiny-blocks/docker-container/blob/main/LICENSE.Public API: unchanged. No code in
srcchanges, so the release is5.0.1.Related issue
None.
Checklist
make reviewpasses.make testspasses. 182 tests, 307 assertions, lines 100% (777/777), MSI 100% (331 of 331 killed).