Repository navigation
feat: support for oidc end session endpoint #1207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
steveiliop56
wants to merge
7
commits into
main
Choose a base branch
from
feat/oidc-rp-logout
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6294f9a
feat: support for oidc end session endpoint
steveiliop56 6f52f48
feat: add frontend for oidc rp logout
steveiliop56 535050c
feat: use error page and logout confirm for rp oidc logout
steveiliop56 81d7bee
Merge branch 'main' into feat/oidc-rp-logout
steveiliop56 a81171a
refactor: fix id token userinfo issues
steveiliop56 cbaed4b
fix: rabbit comments
steveiliop56 67c3f8a
fix: rabbit comments
steveiliop56 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: tinyauthapp/tinyauth
Length of output: 5541
Script executed:
Repository: tinyauthapp/tinyauth
Length of output: 594
Script executed:
sed -n '20,55p' frontend/src/pages/logout-page.tsxRepository: tinyauthapp/tinyauth
Length of output: 1129
Use confirmation text that also fits requests without a redirect.
When
post_logout_redirect_uriis absent,endSessionredirects to/logout?logout_reason=oidc, and the logout page displays “We couldn't verify where to redirect you after logout.” No redirect URI was supplied in this case, so the subtitle is inaccurate. Use neutral confirmation text in both English locale files, and keepfrontend/src/lib/i18n/locales/en.jsonandfrontend/src/lib/i18n/locales/en-US.jsonidentical.