Skip to content

CI: integration and journeys-list tests pass on the runner - #6

Merged
tomeyer97 merged 3 commits into
mainfrom
fix/bugs
Nov 18, 2026
Merged

tomeyer97 merged 3 commits into
mainfrom
fix/bugs

Conversation

@tomeyer97

Copy link
Copy Markdown
Owner

Follow-up to #4: main's CI was red after the merge.

  • Journeys list harness: the focused End row counted as in view within a pixel (rows end at fractions with the runner's fonts).
  • Notes and journeys folders: files already in a just-created folder are read (the watcher can miss files written right after their folder).
  • Integration runner: the CI job's GITHUB_/CI_ variables no longer reach VS Code (the understanding CLI took the branch from them); Add Note's typing wait is a fixed 600 ms again.

🤖 Generated with Claude Code

tomeyer97 and others added 3 commits November 18, 2026 11:55
Rows can end at a fraction of a pixel (DejaVu Sans on the CI runner: 760.36 of 760) while the page scrolls by whole
pixels, so the focused last row was reported as out of view. The failure message now gives the row's edges.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…reated are read

The file watcher starts watching a new folder only once it has seen it, so files written right after the folder
(mkdir -p then a write, a checkout) may come with no event of their own. When the folder, or one above it, is created,
its .json files are read. Integration waits print the loaded journeys' ids on a timeout.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ed after a fixed 600 ms

The runner drops GITHUB_*/GITLAB_*/CI_*/RUNNER_* before starting VS Code: the extension host passed GITHUB_HEAD_REF to
the understanding CLI, and the check suite saw the job's branch instead of its own. Add Note's typing wait is no longer
scaled (3x on CI): after a second or two the test window moves the keyboard out of the new box and the text is lost.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@tomeyer97
tomeyer97 marked this pull request as ready for review November 18, 2026 11:03
@tomeyer97
tomeyer97 merged commit 05f989e into main Nov 18, 2026
2 checks passed
@tomeyer97
tomeyer97 deleted the fix/bugs branch November 18, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant