Skip to content

🐛 fix(api): restore public class definitions - #321

Merged
gaborbernat merged 1 commit into
tox-dev:mainfrom
gaborbernat:fix/public-class-module
Nov 13, 2026
Merged

gaborbernat merged 1 commit into
tox-dev:mainfrom
gaborbernat:fix/public-class-module

Conversation

@gaborbernat

@gaborbernat gaborbernat commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

The simplint adoption moved Index and IndexServer into private modules behind package re-exports. The classes stayed importable from devpi_process, but neither the classes nor their methods kept their original module and source paths. 🐛 Once this merges, both classes and their methods are defined in devpi_process again.

The package root holds the two classes and the _check_call helper they share, and the private modules that held them are removed. Inline lint exceptions cover the root's package-init rules, since keeping the original path is the point of the layout.

@gaborbernat gaborbernat added the bug Something isn't working label Nov 13, 2026
The simplint adoption moved Index and IndexServer into private modules.
Assigning __module__ on the classes alone left method introspection and
source paths changed. Define both classes at the package root again.
@gaborbernat
gaborbernat force-pushed the fix/public-class-module branch from d19c191 to e76eca6 Compare November 13, 2026 01:42
@gaborbernat gaborbernat changed the title 🐛 fix(api): preserve class module identity 🐛 fix(api): restore public class definitions Nov 13, 2026
@gaborbernat
gaborbernat merged commit f62e5a1 into tox-dev:main Nov 13, 2026
19 checks passed
@gaborbernat
gaborbernat deleted the fix/public-class-module branch November 16, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant