Repository navigation
🐛 fix(discovery): keep preferred venv executable - #218
Merged
gaborbernat merged 2 commits intoNov 3, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The preferred-path probe resolved each candidate before checking it. For a symlinked virtual environment executable, discovery returned its base interpreter, so commands launched through the returned path used the base prefix. The reproducer in #191 shows the difference. Discovery now retains the preferred executable path. Fixes #191.
Preferred virtual environment
The probe passes the caller's path to the candidate check. The check still uses the resolved target to identify duplicate candidates but returns the absolute invoked path for interrogation. The probe skips a symlink whose target is missing.
Behavior changes
On POSIX, a preferred virtual environment symlink returns the virtual environment executable. On Windows, discovery retains the selected executable path. Discovery continues to skip candidates with missing symlink targets.
Reported by Anthropic's OSS Scanner:
ANT-2026-D6C7JUEB.