Skip to content

Require patched Node 24 for SDK tooling - #66

Merged
kvz merged 2 commits into
mainfrom
node-security
Oct 21, 2026
Merged

kvz merged 2 commits into
mainfrom
node-security

Conversation

@kvz

@kvz kvz commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

The Node 24 selector and NodeSource bootstrap could reuse a runtime older than the October security fixes, including the native Brotli memory corruption fix.

Require ^24.22.1 with check-latest: true in both CI jobs. The development image now copies Node/npm from the published node:24.22.1-bookworm-slim image instead of running a floating NodeSource installer. Python 3.12–3.14 support, the existing CLI installation, and SDK behavior stay intact.

Validation: the complete Python 3.14 development image built with --pull on amd64 and reported Node 24.22.1, npm 11.19.1, Python 3.14.8, and the Transloadit CLI. In that image, the full coverage suite with TEST_NODE_PARITY=1 passed: 167 tests, 12 existing skips, 94.22% coverage. YAML parsing and git diff --check passed. Council found no correctness issues; the optional suggestion to remove existing development-image apt packages is left outside this runtime-only change. CI passed on all six Linux/Windows × Python 3.12–3.14 lanes, the real API E2E job, and CodeQL. Linux and Windows setup logs confirm Node 24.22.1; native arm64 image execution has not been repeated locally.

🤖 Claimed by kvz on framework1/python-sdk since 2026-10-21 · resume: codex resume 01a15e32-a05f-7153-89c2-0b1273795a49

@kvz kvz self-assigned this Oct 21, 2026
@kvz
kvz requested a review from tim-kos October 21, 2026 17:12
@codecov-commenter

codecov-commenter commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.71%. Comparing base (46a98f3) to head (df26795).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage   95.71%   95.71%           
=======================================
  Files          15       15           
  Lines         933      933           
  Branches      130      130           
=======================================
  Hits          893      893           
  Misses         40       40           
Flag Coverage Δ
unittests 95.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kvz
kvz marked this pull request as ready for review October 21, 2026 17:16
@kvz
kvz merged commit 50049eb into main Oct 21, 2026
9 checks passed
@kvz
kvz deleted the node-security branch October 21, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants