Repository navigation
Require patched Node 24 for SDK tooling - #66
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
=======================================
Coverage 95.71% 95.71%
=======================================
Files 15 15
Lines 933 933
Branches 130 130
=======================================
Hits 893 893
Misses 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kvz
marked this pull request as ready for review
October 21, 2026 17:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Node 24 selector and NodeSource bootstrap could reuse a runtime older than the October security fixes, including the native Brotli memory corruption fix.
Require
^24.22.1withcheck-latest: truein both CI jobs. The development image now copies Node/npm from the publishednode:24.22.1-bookworm-slimimage instead of running a floating NodeSource installer. Python 3.12–3.14 support, the existing CLI installation, and SDK behavior stay intact.Validation: the complete Python 3.14 development image built with
--pullon amd64 and reported Node 24.22.1, npm 11.19.1, Python 3.14.8, and the Transloadit CLI. In that image, the full coverage suite withTEST_NODE_PARITY=1passed: 167 tests, 12 existing skips, 94.22% coverage. YAML parsing andgit diff --checkpassed. Council found no correctness issues; the optional suggestion to remove existing development-image apt packages is left outside this runtime-only change. CI passed on all six Linux/Windows × Python 3.12–3.14 lanes, the real API E2E job, and CodeQL. Linux and Windows setup logs confirm Node 24.22.1; native arm64 image execution has not been repeated locally.🤖 Claimed by kvz on
framework1/python-sdksince 2026-10-21 · resume:codex resume 01a15e32-a05f-7153-89c2-0b1273795a49