Repository navigation
Fix LCM rounding - #2256
Open
qownain wants to merge 1 commit into
Open
Fix LCM rounding#2256qownain wants to merge 1 commit into
qownain wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current formula multiplies before dividing by the GCD. That intermediate product can lose precision even when the inputs and final result are safe integers.
For example,
leastCommonMultiple(9007199254740990, 3)returns9007199254740989. Dividing first gives the correct result,9007199254740990.This changes the order of operations and adds regression tests for swapped arguments and negative values. Zero handling stays the same.
Validation: ESLint passes, all 588 tests across 178 suites pass, and the LCM implementation has 100% statement, branch, function, and line coverage. The new regression test fails before the fix.
Prepared with Codex assistance.