Repository navigation
Render child machines with MachineState and provide per-owner layers through createMachineContext - #243
Merged
Conversation
…through createMachineContext MachineState accepts a child bridge and renders `inactive` while the owning state is not active. useMachineResult exposes the hydration-safe result reader for custom hooks. createMachineContext factories can declare a Layer parameter that the Provider supplies through a typed `layer` prop. AtomMachine.isMachineAtom tells machine bridges from child bridges. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H9xMXPkpeqmvAbWNGY7R55
Contributor
Type performanceMeasured with TypeScript 6.0.3 and
Marginal instantiations are measured against the matching setup without that API call:
Check times (informational)
Type instantiations are the comparison metric. Check time varies with runner load and is informational only. |
Contributor
Runtime performanceMedian of 5 independent benchmark processes on Pull request baseline
Process runtime reference points
Effect Machine change from base
Process runtime reference change from base
Regression guardNo large, noise-adjusted throughput or heap regressions detected. Versions and interpretation
Higher throughput is better; lower heap is better. Variability is the median absolute deviation across independent processes, relative to their median. Small differences on shared GitHub-hosted hardware remain informational; the required guard rejects only large changes beyond the measured noise allowance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MachineStateaccepts a child bridge (machine.child(Descriptor)) as well as a machine bridge. Paths and thechildrensnapshot are typed by the child machine (ChildMachineAtom.State<A>), andinactivealso renders while the state that owns the child is not active.MachineStatePropsis nowMachineStateProps<A, Path>, withMachineStateProps.BridgeandMachineStateProps.State<A>.useMachineResult(atom): the non-suspending, hydration-safe reader behindMachineState(server value during SSR and hydration, keeps the lastSuccesswhile the atom isInitialagain) for custom readers ofselect,matches,can, and other result atoms.createMachineContextfactories can declare a second,Layer-typed parameter for per-owner capabilities. The Provider then requires alayerprop of exactly that type (and rejects it otherwise); likeinput, it is read once when the owner mounts. Factories that need a layer but no input declare the first parameter asvoid. NewMachineContext.ArgsandMachineContext.ProviderProps<Args>types.AtomMachine.isMachineAtomto tell machine bridges from child bridges;MachineStateuses it to chooseselectSnapshotorselectSnapshotChild.console.error), inactive owner state rendersinactive,useMachineResultnever returnsInitialafter aSuccessduring startup, per-owner layers (independent implementations per Provider, layer read once per React key). Typetests for child paths and snapshots,useMachineResult,layerrequired/rejected, and a layer missing the machine's service being a compile error.createMachineContextform; render and child sections document child bridges anduseMachineResult; React README updated.Changeset
minorfor@typeonce/effect-machineand@typeonce/effect-machine-react(fixed group).Validation
pnpm check(format check via dprint with the pinned plugin versions locally;packages/devtools/test/StaticSite.test.tstimes out locally on unchangedmainas well)pnpm test:types,pnpm perf:types, andpnpm perf:runtimeran locally. The widenedMachineStateadds a negligible number of instantiations to the existing React typetest scenarios compared withmain.Generated by Claude Code