Repository navigation
Conversation
manjari25
added this pull request to stack #883
October 16, 2026 20:28
manjari25
marked this pull request as ready for review
October 16, 2026 22:01
manjari25
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 16, 2026 22:01
manjari25
force-pushed
the
manjari/tango-signature-cache
branch
from
October 16, 2026 22:06
fe144a0 to
1fafd1f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The Tango-backed conflict analyzer compares a new batch against the signature of every in-flight batch. Reading all of those from the signature store on every analysis would be slow, especially after a restart. This PR adds the in-memory cache that sits in front of the store.
What?
Everything is added under
submitqueue/extension/conflict/tango:TargetSignatures, keyed by queue and batch ID. One cache serves every queue, with a single memory budget, so a busy queue can use space an idle one left behind.Targets.-race.Test Plan
./tool/bazel test //submitqueue/extension/conflict/tango/...go test -race ./submitqueue/extension/conflict/tango/make check-gazellemake check-mocksmake lintCI
Issue