Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plugins/communication_protocols/socket/old_tests/containing 1,500 lines of 100% commented-out tests from a pre-1.0 refactor.plugins/communication_protocols/socket/INCOMPLETEmarker file.plugins/communication_protocols/socket/tests/(8/8 pass).Motivation
Cleans up dead code and stale artifacts that confuse contributors and pollute codebase searches.
Testing
pytest plugins/communication_protocols/socket/tests/(8 passed).Summary by cubic
Removes the commented-out pre-1.0 socket tests and the empty
INCOMPLETEmarker file to clean up dead code inplugins/communication_protocols/socket/.old_tests/and the 0-byteINCOMPLETEfile.tests/are unaffected and continue to pass (8/8).Written for commit d1dcef9. Summary will update on new commits.