Skip to content

chore(socket): remove legacy commented-out tests and empty marker file - #121

Open
Sooriya04 wants to merge 1 commit into
universal-tool-calling-protocol:mainfrom
Sooriya04:fix/remove-socket-dead-code
Open

Sooriya04 wants to merge 1 commit into
universal-tool-calling-protocol:mainfrom
Sooriya04:fix/remove-socket-dead-code

Conversation

@Sooriya04

@Sooriya04 Sooriya04 commented Nov 4, 2026 •

Copy link
Copy Markdown

Summary

  • Remove plugins/communication_protocols/socket/old_tests/ containing 1,500 lines of 100% commented-out tests from a pre-1.0 refactor.
  • Remove the unused 0-byte plugins/communication_protocols/socket/INCOMPLETE marker file.
  • Active socket tests continue running normally in plugins/communication_protocols/socket/tests/ (8/8 pass).

Motivation

Cleans up dead code and stale artifacts that confuse contributors and pollute codebase searches.

Testing

  • Ran pytest plugins/communication_protocols/socket/tests/ (8 passed).

Summary by cubic

Removes the commented-out pre-1.0 socket tests and the empty INCOMPLETE marker file to clean up dead code in plugins/communication_protocols/socket/.

  • Deletes ~1,500 lines of fully commented-out tests from old_tests/ and the 0-byte INCOMPLETE file.
  • Live tests in tests/ are unaffected and continue to pass (8/8).

Written for commit d1dcef9. Summary will update on new commits.

View guided diff

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

View guided diff | Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant