Repository navigation
[Patch] Persist TextureStreamingSystem profile in SceneSerializer - #1406
Merged
Merged
Conversation
Scene serializer had no hook for TextureStreamingSystem's active tuning profile, so a profile set via apply(.archviz) etc. was lost on reload in a different host app or the Editor. Fixes #1404
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TextureStreamingSystem's active tuning profile, so a profile set viaapply(.archviz)etc. was lost on reload in a different host app or the Editor.TextureStreamingSystem.activeProfiletracking, aSceneData.textureStreamingProfilefield, and save/load wiring inSceneSerializer, following the existingAntiAliasingData/tonemap pattern.applyproperty overrides), per the scope decision in the issue.Fixes #1404
Test plan
swift buildsucceedsswift build --target UntoldEngineRenderTestssucceedstestSerializeTextureStreamingProfile/testDeserializeTextureStreamingProfiletoSceneSerializerTest.swift(currently skipped along with the rest of that suite during its.untoldformat migration)