Repository navigation
[Patch] Stop clear glass from writing its own depth over passthrough - #1412
Merged
Merged
Conversation
In mixed immersion, every transparent draw wrote its own depth into the compositor submission, including clear panes with nothing virtual behind them. That stamped the glass plane's near-field depth over real-world passthrough, mismatching the compositor's reprojection of the actual (unrelated, usually farther) real object on head rotation and smearing it. Only frosted/self-showing panes need to write their own depth; clear panes now leave the depth of whatever is behind them, matching the existing non-mixed XR behavior. Fixes #1411
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isGlass && material.paneShowsItselfgate (already used for non-mixed XR) to mixed mode too, so only frosted/self-showing panes write their own depth; clear panes leave the depth of whatever is behind them, same as other XR modes.Test plan
swift buildsucceeds.Fixes #1411