Skip to content

fix[frontend](pipeline-filters): improved pipeline filter repath gene… - #2962

Merged
AlexSanchez-bit merged 2 commits into
release/v12.0.0from
backlog/v12_pipeline_naming
Oct 22, 2026
Merged

AlexSanchez-bit merged 2 commits into
release/v12.0.0from
backlog/v12_pipeline_naming

Conversation

@AlexSanchez-bit

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

🛑 AI review — High/critical findings

One or more high/critical issues were found. Please review and fix before merging if they're real.

✅ architecture (silas-1.7-pro) — clean

Summary: Frontend display-name and filename sanitization changes only; no architectural, contract, agent, migration, or CI impact.

No findings.

🛑 bugs (silas-1.7-pro) — high/critical — please review

Summary: displayName uses slice(0,-5) which can return an empty or wrong name, and sanitizeFileName no longer trims leading/trailing underscores.

  • high frontend/src/features/parsing-filters/lib/filter-model.ts:12 — splitted.slice(0,-5) removes the last 5 elements instead of limiting to the first few. For a 5-part name like 'a-b-c-d-e.yaml', split length is 5 and slice(0,-5) returns [], so displayName returns an empty string. For 6+ parts it also returns an unexpected number of segments. Use slice(0, 4) or slice(0, 5) depending on intent.
  • medium frontend/src/features/parsing-filters/lib/filter-model.ts:27 — sanitizeFileName now replaces non-alphanumeric characters with '' but still trims only leading/trailing hyphens. Inputs like 'foo' or 'foo' produce 'foo.yaml' or 'foo_.yaml' instead of 'foo.yaml'. Update the trim regex to /^[-]+|[-]+$/g or use /^+|+$/g if underscores are the only separator.

✅ security (silas-1.7-pro) — clean

Summary: No vulnerabilities introduced; changes affect display-name formatting and filename sanitization without creating a security impact.

No findings.

🔴 go-deps — pending updates

🔍 Discovered 31 Go projects

📦 Dependencies with updates available:

  📁 ./plugins/gcp:
     - google.golang.org/api: v0.305.0 → v0.308.0

  📁 ./plugins/aws:
     - github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs: v1.90.0 → v1.90.1

  📁 ./backend:
     - google.golang.org/api: v0.305.0 → v0.308.0

  📁 ./tools/rulecheck:
     - github.com/threatwinds/go-sdk: v1.1.31 → v1.1.38

  📁 ./agent-manager:
     - github.com/threatwinds/go-sdk: v1.1.31 → v1.1.38

  📁 ./log-input:
     - github.com/threatwinds/go-sdk: v1.1.31 → v1.1.38

  📁 ./agent:
     - github.com/threatwinds/go-sdk: v1.1.28 → v1.1.38

  📁 ./collectors/utmstack:
     - github.com/threatwinds/go-sdk: v1.1.31 → v1.1.38

  📁 ./collectors/forwarder:
     - github.com/threatwinds/go-sdk: v1.1.31 → v1.1.38

  📁 ./collectors/as400:
     - github.com/threatwinds/go-sdk: v1.1.31 → v1.1.38

❌ Please update dependencies before merging.

…acter into underscore

Signed-off-by: Alex Sánchez  <alex.sanchez@utmstack.com>
@AlexSanchez-bit
AlexSanchez-bit merged commit 8ef4a70 into release/v12.0.0 Oct 22, 2026
1 check passed
@AlexSanchez-bit
AlexSanchez-bit deleted the backlog/v12_pipeline_naming branch October 22, 2026 18:56
@AlexSanchez-bit AlexSanchez-bit linked an issue Oct 22, 2026 that may be closed by this pull request
2 of 3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pipeline multy type not parsing

1 participant