Skip to content

fix[frontend](alert-tagrule): added scroll to the table of alert tagr… - #2963

Merged
osmontero merged 1 commit into
v11from
backlog/v11_tagrules_scroll
Oct 23, 2026
Merged

osmontero merged 1 commit into
v11from
backlog/v11_tagrules_scroll

Conversation

@AlexSanchez-bit

Copy link
Copy Markdown
Contributor

No description provided.

@AlexSanchez-bit
AlexSanchez-bit requested a review from a team October 22, 2026 18:53
@github-actions

Copy link
Copy Markdown

❌ Go dependencies check failed

There are outdated Go dependencies, or modules that could not be inspected.
Run bash .github/scripts/go-deps.sh --update --discover locally and
commit the updated go.mod / go.sum files.

Script output
🔍 Discovered 25 Go projects

📦 Dependencies with updates available:

  📁 ./plugins/gcp:
     - google.golang.org/api: v0.299.0 → v0.308.0

  📁 ./plugins/aws:
     - github.com/aws/aws-sdk-go-v2: v1.47.0 → v1.47.4
     - github.com/aws/aws-sdk-go-v2/config: v1.33.5 → v1.33.10
     - github.com/aws/aws-sdk-go-v2/credentials: v1.20.5 → v1.20.10
     - github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs: v1.88.0 → v1.90.1

  📁 ./plugins/alerts:
     - github.com/tidwall/gjson: v1.19.0 → v1.20.0

  📁 ./plugins/events:
     - github.com/tidwall/gjson: v1.19.0 → v1.20.0

  📁 ./plugins/modules-config:
     - github.com/Azure/azure-sdk-for-go/sdk/storage/azblob: v1.8.1 → v1.8.2
     - github.com/aws/aws-sdk-go-v2/config: v1.33.5 → v1.33.10
     - github.com/aws/aws-sdk-go-v2/credentials: v1.20.5 → v1.20.10
     - github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs: v1.88.0 → v1.90.1
     - github.com/aws/aws-sdk-go-v2/service/sts: v1.51.0 → v1.51.5
     - github.com/crowdstrike/gofalcon: v0.22.0 → v0.23.0
     - golang.org/x/sync: v0.23.0 → v0.24.0
     - google.golang.org/api: v0.299.0 → v0.308.0

  📁 ./plugins/azure:
     - github.com/Azure/azure-sdk-for-go/sdk/azcore: v1.23.1 → v1.23.3
     - github.com/Azure/azure-sdk-for-go/sdk/storage/azblob: v1.8.1 → v1.8.2

  📁 ./plugins/crowdstrike:
     - github.com/crowdstrike/gofalcon: v0.22.0 → v0.23.0

  📁 ./plugins/geolocation:
     - github.com/tidwall/gjson: v1.19.0 → v1.20.0

  📁 ./installer:
     - github.com/cloudfoundry/gosigar: v1.3.127 → v1.3.128

  📁 ./agent:
     - github.com/netsampler/goflow2: v1.3.7 → v1.3.8
     - golang.org/x/sys: v0.48.0 → v0.49.0

�[0;31m❌ Please update dependencies before merging.�[0m

@github-actions

Copy link
Copy Markdown

✅ AI review — Approved with warnings

Only minor (medium/low) issues were found. They won't block the merge, but consider addressing them.

✅ architecture (silas-1.7-pro) — clean

Summary: No architectural deviations detected; changes are limited to frontend table layout, styling, and a minor template escape fix.

No findings.

⚠️ bugs (silas-1.7-pro) — non-blocking warnings

Summary: No blocking bugs found; one minor layout inconsistency introduced by fixed table layout and stale cell width.

  • low frontend/src/app/data-management/alert-management/alert-rules/alert-rules.component.html:70 — The Description column header is now set to 25%, but this data cell still has style="width: 35%". With the new table-layout: fixed rule, first-row header widths control column sizing, so the stale 35% cell width can cause an inconsistent Description column layout.

✅ security (silas-1.7-pro) — clean

Summary: No vulnerabilities or information disclosures introduced by the diff.

No findings.

@utmstackprapprover utmstackprapprover Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested — Go dependencies check failed (see above).

@osmontero
osmontero merged commit 6aeba85 into v11 Oct 23, 2026
5 of 7 checks passed
@osmontero
osmontero deleted the backlog/v11_tagrules_scroll branch October 23, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants