Repository navigation
[v8] Migrate off deprecated V8 15.8 APIs - #265
Conversation
Migrate ArrayBufferView::Buffer() and WasmMemoryObject::Buffer() calls to GetBuffer() (returning Local<ArrayBufferBase>), RegExp::Exec() to RegExp::ExecV2(), and OwnedBuffer::buffer/size to OwnedBuffer::as_span() in preparation for advancing these V8 15.8 deprecations to V8_DEPRECATED. Refs: https://crrev.com/c/8714721
|
@pthier PTAL |
|
Oh, wait, it looks like this node branch does not see the new API yet. How does this work? Does this not build against V8 ToT? |
Jetski tells me this is just an artifact of how the Github actions are configured and can be ignored. So we can land this and it will not cause issues. |
|
FYI: Compilation and all tests pass locally. |
Yep I agree. On our CQ when running node-ci we pull in V8 ToT. |
Migrate
ArrayBufferView::Buffer()andWasmMemoryObject::Buffer()calls toGetBuffer()(returningLocal<ArrayBufferBase>),RegExp::Exec()toRegExp::ExecV2(), andOwnedBuffer::buffer/sizetoOwnedBuffer::as_span()in preparation for advancing these V8 15.8 deprecations to V8_DEPRECATED.Refs: https://crrev.com/c/8714721