Skip to content

[v8] Migrate off deprecated V8 15.8 APIs - #265

Merged
pthier merged 1 commit into
v8:node-ci-2026-10-29from
backes:v8-15.8-deprecations
Nov 4, 2026
Merged

pthier merged 1 commit into
v8:node-ci-2026-10-29from
backes:v8-15.8-deprecations

Conversation

@backes

@backes backes commented Nov 4, 2026

Copy link
Copy Markdown
Member

Migrate ArrayBufferView::Buffer() and WasmMemoryObject::Buffer() calls to GetBuffer() (returning Local<ArrayBufferBase>), RegExp::Exec() to RegExp::ExecV2(), and OwnedBuffer::buffer/size to OwnedBuffer::as_span() in preparation for advancing these V8 15.8 deprecations to V8_DEPRECATED.

Refs: https://crrev.com/c/8714721

Migrate ArrayBufferView::Buffer() and WasmMemoryObject::Buffer() calls
to GetBuffer() (returning Local<ArrayBufferBase>), RegExp::Exec() to
RegExp::ExecV2(), and OwnedBuffer::buffer/size to OwnedBuffer::as_span()
in preparation for advancing these V8 15.8 deprecations to
V8_DEPRECATED.

Refs: https://crrev.com/c/8714721
@backes

backes commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

@pthier PTAL

@backes

backes commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

Oh, wait, it looks like this node branch does not see the new API yet. How does this work? Does this not build against V8 ToT?

@backes

backes commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

Oh, wait, it looks like this node branch does not see the new API yet. How does this work? Does this not build against V8 ToT?

Jetski tells me this is just an artifact of how the Github actions are configured and can be ignored. So we can land this and it will not cause issues.

@backes

backes commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

FYI: Compilation and all tests pass locally.

@pthier

pthier commented Nov 4, 2026

Copy link
Copy Markdown

Oh, wait, it looks like this node branch does not see the new API yet. How does this work? Does this not build against V8 ToT?

Jetski tells me this is just an artifact of how the Github actions are configured and can be ignored. So we can land this and it will not cause issues.

Yep I agree. On our CQ when running node-ci we pull in V8 ToT.

@pthier
pthier merged commit f4878eb into v8:node-ci-2026-10-29 Nov 4, 2026
13 of 29 checks passed
@backes
backes deleted the v8-15.8-deprecations branch November 4, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants