Repository navigation
Honor explicit shutdown policy during cleanup retry - #32
Merged
Merged
Conversation
Owner
Author
|
Reviewed the three shutdown-policy transitions: omitted flag preserves prior intent, reopening finishes prior cleanup, and explicit false suppresses another shutdown attempt. The regression case failed before the fix. Exact-tree local release checks and Linux CI now pass with 297 tests and one existing skip: https://github.com/viralcodex/opencode-demul/actions/runs/42034990622. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
A retry with explicit
shutdown: falsemust not retry an earlier power-off request. Preserve previous shutdown intent only when the retry omits the flag. This lets callers finish cleanup without another shutdown attempt.Verification
Final corrective PR before publishing the already-prepared v0.4.0 release.