Skip to content

Honor explicit shutdown policy during cleanup retry - #32

Merged
viralcodex merged 1 commit into
mainfrom
fix/explicit-shutdown-policy
Nov 5, 2026
Merged

viralcodex merged 1 commit into
mainfrom
fix/explicit-shutdown-policy

Conversation

@viralcodex

Copy link
Copy Markdown
Owner

Fix

A retry with explicit shutdown: false must not retry an earlier power-off request. Preserve previous shutdown intent only when the retry omits the flag. This lets callers finish cleanup without another shutdown attempt.

Verification

  • Extended the existing close/reopen transition table with explicit detach, rather than adding duplicate setup.
  • The new case failed before the fix and passes after it.
  • release:check passes with 297 tests and one existing Bun-only skip.
  • Controller and native lifecycle suites pass three repeated runs.
  • Rebuilt the GUI bundle and updated the v0.4.0 release notes.

Final corrective PR before publishing the already-prepared v0.4.0 release.

@viralcodex

Copy link
Copy Markdown
Owner Author

Reviewed the three shutdown-policy transitions: omitted flag preserves prior intent, reopening finishes prior cleanup, and explicit false suppresses another shutdown attempt. The regression case failed before the fix. Exact-tree local release checks and Linux CI now pass with 297 tests and one existing skip: https://github.com/viralcodex/opencode-demul/actions/runs/42034990622.

@viralcodex
viralcodex merged commit 6dd9880 into main Nov 5, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant