Skip to content

fix(migrate): preserve Oxlint inheritance with shared TS configs - #3097

Draft
fengmk2 wants to merge 19 commits into
mainfrom
fix/migrate-oxlint-extends
Draft

fengmk2 wants to merge 19 commits into
mainfrom
fix/migrate-oxlint-extends

Conversation

@fengmk2

@fengmk2 fengmk2 commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

vp migrate copies JSON extends paths into lint.extends, but vp lint requires config objects.

The migrator now creates shared TypeScript configs and imports them, including nested inheritance. All migrated consumers, including the owning workspace, import the same module. Shared rule edits apply to every consumer. Migration defaults stay in each workspace's local lint block. Rule order, severities, overrides, and explicit options remain intact.

The owner references its own env, globals, settings, and ignorePatterns at the top level. Other consumers keep their own settings and exclusions. Plugin declarations stay in their original config or override. Relative plugin paths resolve from import.meta.url. Original shared JSON files remain available to other consumers.

Conflicts or unsupported configs leave the original JSON in place with a warning. Workspace cleanup waits until all migration outcomes are known. Each workspace must complete its own merge before cleanup can remove its JSON path, even when multiple symlinks share a source. Cleanup retains the transitive JSON dependencies of preserved consumers and symlink targets.

Generated modules record their source. Later migration attempts reuse them without replacing user edits, so preserved consumers can migrate after their conflicts are resolved.

Fixes #3089

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://fix-migrate-oxlint-extends-viteplus-dev.voidzero-docs.workers.dev (commit 6068e7a)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: In progress 🔵

View logs ↗
18def62 2026-10-19T15:08:57.776Z View logs ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://a2c9a497-viteplus-dev.voidzero-docs.workers.dev 6068e7a 2026-10-19T10:35:07.352Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://a3c237f8-viteplus-dev.voidzero-docs.workers.dev 08b5d62 2026-10-19T10:22:56.543Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://8b7200b8-viteplus-dev.voidzero-docs.workers.dev 702fa7c 2026-10-19T10:11:50.773Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://9cb495b9-viteplus-dev.voidzero-docs.workers.dev 7e4885d 2026-10-19T09:46:56.872Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://fac31636-viteplus-dev.voidzero-docs.workers.dev 3f568fe 2026-10-19T09:26:06.619Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://f36b9712-viteplus-dev.voidzero-docs.workers.dev 0d030c9 2026-10-19T09:07:53.157Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://973137d7-viteplus-dev.voidzero-docs.workers.dev 37aef27 2026-10-19T07:33:52.826Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://f9b997c3-viteplus-dev.voidzero-docs.workers.dev 5973b90 2026-10-18T11:12:54.239Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://9c09b3e0-viteplus-dev.voidzero-docs.workers.dev eda4fca 2026-10-18T10:40:08.246Z Visit the dashboard ↗

View all previews: View all previews ↗

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

✅ Staging deployment successful!

Preview: https://viteplus-staging.void.app/
Commit: d973b5c

@fengmk2 fengmk2 changed the title fix(migrate): resolve Oxlint JSON extends fix(migrate): preserve Oxlint inheritance with shared TS configs Oct 17, 2026
@fengmk2
fengmk2 force-pushed the fix/migrate-oxlint-extends branch from bf0e041 to 3b7e402 Compare October 17, 2026 17:07
@fengmk2
fengmk2 force-pushed the fix/migrate-oxlint-extends branch from 0877f9f to cac98a4 Compare October 18, 2026 03:58
@fengmk2

fengmk2 commented Oct 19, 2026

Copy link
Copy Markdown
Member Author

@codex review

@fengmk2 fengmk2 self-assigned this Oct 19, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-19T15:54:33.142703Z d973b5c Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5973b90c51

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/cli/src/migration/migrator/oxlint-config.ts
Comment thread packages/cli/src/migration/migrator/vite-config.ts
Comment thread packages/cli/src/migration/migrator/vite-config.ts Outdated
@fengmk2

fengmk2 commented Oct 19, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 37aef27bf2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/cli/src/migration/migrator/oxlint-config.ts Outdated
@fengmk2

fengmk2 commented Oct 19, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0d030c95ee

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/cli/src/migration/migrator/oxlint-config.ts Outdated
Comment thread packages/cli/src/migration/migrator/vite-config.ts Outdated
@fengmk2

fengmk2 commented Oct 19, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3f568fe1dc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/cli/src/migration/migrator/oxlint-config.ts Outdated
Comment thread packages/cli/src/migration/migrator/oxlint-config.ts Outdated
@fengmk2

fengmk2 commented Oct 19, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7e4885d57b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/cli/src/migration/migrator/oxlint-config.ts
Comment thread packages/cli/src/migration/migrator/vite-config.ts Outdated
Comment thread packages/cli/src/migration/migrator/oxlint-config.ts
@fengmk2

fengmk2 commented Oct 19, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 702fa7ce76

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@fengmk2

fengmk2 commented Oct 19, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 08b5d6290a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/cli/src/migration/migrator/oxlint-config.ts
@fengmk2

fengmk2 commented Oct 19, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: 6068e7a851

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@fengmk2

fengmk2 commented Oct 19, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 18def623da

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/cli/src/migration/migrator/vite-config.ts Outdated
Comment thread packages/cli/src/migration/migrator/oxlint-config.ts
Comment thread packages/cli/src/migration/migrator/vite-config.ts
@fengmk2

fengmk2 commented Oct 19, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 58df1cb399

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/cli/src/migration/migrator/vite-config.ts Outdated
Comment thread packages/cli/src/migration/migrator/vite-config.ts Outdated
Comment thread packages/cli/src/migration/migrator/oxlint-config.ts Outdated
@fengmk2

fengmk2 commented Oct 19, 2026

Copy link
Copy Markdown
Member Author

@codex review

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vp migrate copies string extends paths from .oxlintrc.json into lint, which vp lint rejects

1 participant