Skip to content

chore(deps): bump tokio to 1.54.1 - #889

Merged
wan9chi merged 1 commit into
mainfrom
cursor/bump-tokio-asyncfd-9ede
Oct 26, 2026
Merged

wan9chi merged 1 commit into
mainfrom
cursor/bump-tokio-asyncfd-9ede

Conversation

@wan9chi

@wan9chi wan9chi commented Oct 26, 2026

Copy link
Copy Markdown
Member

Motivation

Security Analysis fails because RUSTSEC-2026-0386 matches tokio 1.49.0 in Cargo.lock. AsyncFd::new and the related constructors accept any AsRawFd, so safe code can register a file descriptor it does not own. The patched releases are tokio 1.51.6, 1.53.3, and 1.54.0. 1.54.0 is yanked, so this pins 1.54.1 and raises the workspace requirement to 1.53.3, the first 1.53 release that adds AsyncFd::register.

Tokio 1.54.1 deprecates AsyncFd::new. CI builds with warnings denied, so the seccomp notify listener registers its owned notification fd with AsyncFd::register.

This is the failure in https://github.com/voidzero-dev/vite-task/actions/runs/40276299983/job/121419811391 on #887. The same lockfile is on main, so the check fails for that pull request and any other one opened against it.

Open in Web Open in Cursor 

RUSTSEC-2026-0386 flags tokio 1.49.0, which fails Security Analysis.
1.54.1 deprecates AsyncFd::new, so the seccomp notify listener registers
its owned fd with AsyncFd::register.

Co-authored-by: Grok 4.7 <noreply@x.ai>
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedcargo/​tokio@​1.49.0 ⏵ 1.54.155 -510093100100

View full report

@github-actions

Copy link
Copy Markdown

fspy benchmark

linux

dynamic/launch             change  -0.06%  [ -3.97% ..  +5.77%]  overhead   +55.37%
dynamic/access             change  -0.41%  [ -3.92% ..  +4.11%]  overhead   +22.23%
dynamic/access-relative    change  +0.57%  [ -3.69% ..  +3.93%]  overhead   +67.66%
dynamic/access-contended   change  +0.64%  [ -3.89% ..  +9.28%]  overhead   +40.50%
static/launch              change  +0.96%  [ -2.97% ..  +5.25%]  overhead  +193.49%
static/access              change  -0.22%  [ -2.16% ..  +0.98%]  overhead +1372.03%
static/access-relative     change  -0.09%  [ -1.75% ..  +1.89%]  overhead +1844.38%
static/access-contended    change  +0.14%  [ -1.71% ..  +2.23%]  overhead +2429.82%

macos

dynamic/launch             change  -0.82%  [ -5.96% ..  +4.71%]  overhead  +235.04%
dynamic/access             change  -1.11%  [-13.91% ..  +4.24%]  overhead    +2.27%
dynamic/access-relative    change  -1.06%  [ -4.13% ..  +2.34%]  overhead  +265.56%
dynamic/access-contended   change  +0.78%  [ -9.79% ..  +6.75%]  overhead    +3.48%

windows

dynamic/launch             change  -0.37%  [ -3.46% ..  +2.49%]  overhead   +30.63%
dynamic/access             change  +0.00%  [ -0.43% ..  +0.43%]  overhead    +1.31%
dynamic/access-relative    change  +0.00%  [ -0.43% ..  +0.43%]  overhead    +1.09%
dynamic/access-contended   change  -0.21%  [ -0.63% ..  +0.42%]  overhead    +1.28%

@wan9chi
wan9chi merged commit e49dd1c into main Oct 26, 2026
21 checks passed
@wan9chi
wan9chi deleted the cursor/bump-tokio-asyncfd-9ede branch October 26, 2026 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants