Repository navigation
chore(deps): bump tokio to 1.54.1 - #889
Merged
Merged
Conversation
RUSTSEC-2026-0386 flags tokio 1.49.0, which fails Security Analysis. 1.54.1 deprecates AsyncFd::new, so the seccomp notify listener registers its owned fd with AsyncFd::register. Co-authored-by: Grok 4.7 <noreply@x.ai>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
fspy benchmarklinuxmacoswindows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Security Analysis fails because RUSTSEC-2026-0386 matches
tokio1.49.0 inCargo.lock.AsyncFd::newand the related constructors accept anyAsRawFd, so safe code can register a file descriptor it does not own. The patched releases are tokio 1.51.6, 1.53.3, and 1.54.0. 1.54.0 is yanked, so this pins 1.54.1 and raises the workspace requirement to 1.53.3, the first 1.53 release that addsAsyncFd::register.Tokio 1.54.1 deprecates
AsyncFd::new. CI builds with warnings denied, so the seccomp notify listener registers its owned notification fd withAsyncFd::register.This is the failure in https://github.com/voidzero-dev/vite-task/actions/runs/40276299983/job/121419811391 on #887. The same lockfile is on main, so the check fails for that pull request and any other one opened against it.