Repository navigation
Fix the design system audit findings, and add three visual changes - #153
Merged
Merged
Conversation
…wrap The theme switch's buttons reset with all: unset, which outranked the shared focus rule, so keyboard focus drew no ring. The focus rule now uses :is() instead of :where(), so it outranks every reset control. A figure's source line is also a nav link, and the nav link's nowrap made a long source overflow a phone. A source line now wraps. Both fixes come from the design system. A browser test checks the switch's ring. Signed-off-by: Will Manning <will@willmanning.io>
…l bench's chrome On the homepage card, Parquet's, Lance's, and Arrow's bars draw at 42%, so Vortex's Blue is the one solid bar and leads even where another bar is longer. Every bar still prints its value. The blog index's heading carries a dim still of the ASCII mark in its top right corner, as plain mono text. scripts/mark-frame.mjs captures it from the homepage's reduced-motion frame. Phones leave it out. Bench's title and toolbar buttons are mono capitals, its ranks are muted so Blue marks only ratios, and its count badges are square. The skin's tests now allow font size, tracking, and case for these labels. Signed-off-by: Will Manning <will@willmanning.io>
…layer CI cannot reach the design system, so a hand edit to one of its copies went unseen. Each copied stylesheet now records the command that made it and a sha256 of the rest of the file, and vendor/vortex-design has a SHA256SUMS file. tests/unit/styles.test.ts fails when a copy no longer matches. The copies also bring the system's new Page layout layer (vx-page, vx-band, vx-page-head, and vx-split), headings that take ink by default, and renderBars, which draws one comparison outside the benchmark card. No page uses the layout layer yet, and every heading on the site keeps its colour. Signed-off-by: Will Manning <will@willmanning.io>
The token is Vortex's bar only, so it now reads like chart-parquet, chart-lance, and chart-arrow. The copies also bring the system's shorter docs, with no change to any rule. Signed-off-by: Will Manning <will@willmanning.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Bench preview for |
🔦 Lighthouse audit
Run |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 91a84b6a31
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ry vendored file mark-frame.mjs dropped every "." to remove the dot field, which also removed the mark's own dimmest pixels. It now drops only the field's colour, and it fails with a clear message unless the mark drew in reduced-motion mode. MARK_FRAME is regenerated. The frame is now a data attribute that ::before draws, so Lighthouse's contrast check no longer reads the dim decoration as text (/blog was 96 for accessibility, from 100). The styles test also fails when a vendored module is missing from SHA256SUMS, not only when a listed one changes. Signed-off-by: Will Manning <will@willmanning.io>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fresh review of the design system found bugs and gaps. This PR fixes them on the site.
The copies also include a page layout layer and
renderBars. No page uses them yet.🤖 Generated with Claude Code