Repository navigation
Show "Page not found" in the tab on bench's 404 pages - #200
Conversation
The server sent a bench 404 with the title "Page not found | Vortex". After hydration, the client set the route's own title instead. The catch-all route had no metadata, and the chart route returned none for an unknown chart, so the tab showed the layout's "Benchmarks | Vortex". Both routes now export the 404's metadata, from one module that not-found.tsx also uses. A smoke test checks the title on both routes after hydration. Signed-off-by: Will Manning <will@willmanning.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🔦 Lighthouse audit
Run |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@codex plz review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
On bench, a missing page showed the tab title "Benchmarks | Vortex". It must show "Page not found | Vortex", as the site does.
The server sent the correct title. After the page loaded, the client set the route's own title. The catch-all route had no title, and the chart route had none for an unknown chart, so the tab used the layout's title.
This PR:
src/bench/lib/not-found-metadata.ts.not-found.tsx, the catch-all route, and the chart route.The bench tests (909) and the smoke tests (192) pass on a local server.
🤖 Generated with Claude Code