Repository navigation
Show pressed filter chips on bench with a light Blue wash - #209
Merged
Merged
Conversation
A pressed chip on bench's Filters panel now takes the system's selected-item look: the accent-soft wash, ink text, and an accent-ink border, in place of the solid accent fill with white text. A press on it darkens the wash, as the windowed chip's does. Will chose this over the fill on 7 Nov after seeing both in both themes. Signed-off-by: Will Manning <will@willmanning.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🔦 Lighthouse audit
Run |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pressed filter chip on bench now shows as a selected item. Before, it was a solid Blue fill with white text. Now it has a light Blue wash, ink text, and a Blue border. This is the design system's rule for a selected item. A press on a pressed chip makes the wash darker, as on the windowed chip.
The image shows the Filters panel in both themes. The left column is production (before). The right column is the same page with the new rule applied (after).
The bench token test now checks the new rule.
🤖 Generated with Claude Code