Repository navigation
Load only the design system CSS the site and bench use - #210
Merged
Merged
Conversation
The design system's copy tool now drops a rule when no file under src names a class the rule needs, and drops the tokens that only such rules read. The copies go from 14.5 KB to 13.7 KB gzipped. Screenshots of the homepage, the blog, a post, the 404, bench, its Filters panel, and its methodology page, in both themes at 1440px and 390px, are the same pixels before and after. Signed-off-by: Will Manning <will@willmanning.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🔦 Lighthouse audit
Run |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The site and bench now load only the design system CSS they use. Nothing on the page changes.
The system's copy tool can now drop a rule when no file under
srcnames a class that the rule needs. It also drops the tokens that only those rules read. The rules that went are for the docs search box, data tables, cards, and large display text, plus some chart and status tokens. The copies go from 14.5 KB to 13.7 KB gzipped.To check, I took screenshots before and after of the homepage, the blog, a post, the 404, bench, its Filters panel, and its methodology page. I did this in both themes at 1440px and 390px. All 28 pairs have the same pixels. Biome, the unit tests, and bench's tests pass.
🤖 Generated with Claude Code