Skip to content

Automatically build on PRs to the community branch #4289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacob1 merged 3 commits into from
Oct 29, 2026
Merged

Automatically build on PRs to the community branch #4289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b57b9a7
Automatically build on PRs to the community branch
jacob1 Oct 26, 2026
0a86768
Fix (upgrade) broken spellcheck workflow
jacob1 Oct 26, 2026
162964c
For PRs, use PR's HEAD sha instead of arbitrary merge commit sha
jacob1 Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/build-platforms.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ on:
tags:
- 'ce-[0-9]*'
workflow_dispatch:
pull_request:
branches:
- 'v3.0-community-edition'

permissions:
contents: read
Expand All @@ -27,7 +30,7 @@ jobs:
id: v
shell: bash
run: |
hash=$(git rev-parse --short=7 HEAD)
hash=$(git rev-parse --short=7 "${{ github.event.pull_request.head.sha || 'HEAD' }}")
desc=$(git describe --tags --long --abbrev=7 --match 'ce-[0-9]*.[0-9]*.[0-9]*' --exclude 'ce-*-*' 2>/dev/null || true)
if [[ $desc =~ ^ce-([0-9]+)\.([0-9]+)\.([0-9]+)-([0-9]+)-g ]]; then
if [ "${BASH_REMATCH[4]}" = 0 ]; then
Expand Down
15 changes: 15 additions & 0 deletions .github/workflows/gibberish.txt
View file
Open in desktop

@reusteur73 reusteur73 Oct 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since CLAUDE.md is no longer in the spellcheck sources, are these additions still needed? None of these words appear in README.md or CONTRIBUTING.md.

@jacob1 jacob1 Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are not needed. But maybe they'll show up in the readme someday too ... decided to include them anyway arbitrarily.

Original file line number Diff line number Diff line change
Expand Up @@ -60,3 +60,18 @@ Kosma
Kosma's
DEV
Modrinth
md
ai
claude
config
NMS
HD
raytrace
renderers
renderer
Shaders
FileTree
MSSQL
servlet
JUnit
JVM
6 changes: 3 additions & 3 deletions .github/workflows/spellcheck.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ on:
jobs:
spellcheck:
name: rojopolis/spellcheck
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- name: actions/checkout
uses: actions/checkout@v2
uses: actions/checkout@v7
- name: rojopolis/spellcheck - actually doing something
uses: rojopolis/spellcheck-github-actions@0.29.0
uses: rojopolis/spellcheck-github-actions@0.66.0
3 changes: 2 additions & 1 deletion .spellcheck.yaml
View file
Open in desktop

@reusteur73 reusteur73 Oct 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that .github/ISSUE_TEMPLATE/*.md are no longer spellchecked (though we probably won't edit those files much)

@jacob1 jacob1 Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I tried to include them, but then it reported a huge number of spelling errors. And I still don't want to maintain the spell checking lol. I think they were never scanned at all based on all the errors, ** must not dive into dot directories.

Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,6 @@ matrix:
- 'code'
- 'pre'
sources:
- '**/*.md'
- 'README.md'
- 'CONTRIBUTING.md'
default_encoding: utf-8
Loading