Skip to content

fix(debug-extensions): resolve Plugin Check errors in the shipped plugin - #839

Open
josephfusco wants to merge 3 commits into
mainfrom
fix/debug-extensions-plugin-check
Open

josephfusco wants to merge 3 commits into
mainfrom
fix/debug-extensions-plugin-check

Conversation

@josephfusco

@josephfusco josephfusco commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Fixes the real errors Plugin Check reports for the wpgraphql-debug-extensions zip. One commit per fix:

  • Requires PHP: 7.4+ → 7.4. Plugin Check only accepts a plain version. 7.4 matches readme.txt and composer.json (^7.4 || ^8.0).
  • ABSPATH guards in activation.php, deactivation.php, and src/Plugin.php.

License

  • Licensed under GPL-2.0-or-later. The plugin header said BSD-0-Clause (linking to BSD-3-Clause), readme.txt said GPL-3, and composer.json said GPL-2.0. All three now say GPL-2.0-or-later, like the other plugins, and the plugin ships the same GPL-2 LICENSE file they do.
  • "Tested up to" stays 6.9, the newest WordPress version the CI matrix tests. Plugin Check will keep reporting "6.9 < 7.1" until WordPress 7.x is added to the matrix.

Testing

  • Built the zip with composer archive and ran wp plugin check wpgraphql-debug-extensions locally in wp-env, using the same options as the workflow in ci: run Plugin Check on the built plugin archive #830. The only error left is "Tested up to: 6.9 < 7.1".
  • php -l passes on the changed files.
Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Assisting with running Plugin Check locally and fixing the errors it reported.

@josephfusco
josephfusco requested review from a team and colinmurphy as code owners October 23, 2026 15:41
@josephfusco josephfusco added [Type] Bug An existing feature is broken [Area] Debug Extensions Issues for the WPGraphQL Debug Extensions plugin Security Work relates to vulnerabilities or hardening Needs Decision Blocked on a maintainer call, not on more work labels Oct 23, 2026
@changeset-bot

changeset-bot Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: de62e78

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

📦 Plugin Artifacts Ready!

Download from GitHub Actions run

Available plugins:

  • ✅ wpgraphql-debug-extensions.zip

See the "Artifacts" section at the bottom of the Actions run page

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

🔍 WordPress Plugin Check Report

❌ Status: Failed

📊 Report

🎯 Total Issues ❌ Errors ⚠️ Warnings
16 16 0

❌ Errors (16)

📁 .phpcs.xml.dist (2 errors)
📍 Line 🔖 Check 💬 Message
0 hidden_files Hidden files are not permitted.
0 application_detected Application files are not permitted.
📁 .env.dist (2 errors)
📍 Line 🔖 Check 💬 Message
0 hidden_files Hidden files are not permitted.
0 application_detected Application files are not permitted.
📁 .editorconfig (1 error)
📍 Line 🔖 Check 💬 Message
0 hidden_files Hidden files are not permitted.
📁 .gitattributes (1 error)
📍 Line 🔖 Check 💬 Message
0 hidden_files Hidden files are not permitted.
📁 phpstan.neon.dist (1 error)
📍 Line 🔖 Check 💬 Message
0 application_detected Application files are not permitted.
📁 bin/build-docker.sh (1 error)
📍 Line 🔖 Check 💬 Message
0 application_detected Application files are not permitted.
📁 bin/_lib.sh (1 error)
📍 Line 🔖 Check 💬 Message
0 application_detected Application files are not permitted.
📁 bin/sync-package-version.sh (1 error)
📍 Line 🔖 Check 💬 Message
0 application_detected Application files are not permitted.
📁 bin/run-codeception.sh (1 error)
📍 Line 🔖 Check 💬 Message
0 application_detected Application files are not permitted.
📁 bin/install-plugins.sh (1 error)
📍 Line 🔖 Check 💬 Message
0 application_detected Application files are not permitted.
📁 bin/install-test-env.sh (1 error)
📍 Line 🔖 Check 💬 Message
0 application_detected Application files are not permitted.
📁 wpgraphql-debug-extensions.php (1 error)
📍 Line 🔖 Check 💬 Message
0 plugin_updater_detected Including An Update Checker / Changing Updates functionality. Plugin Updater detected. Use of the Update URI header is not allowed in plugins hosted on WordPress.org.
📁 readme.txt (1 error)
📍 Line 🔖 Check 💬 Message
0 outdated_tested_upto_header Tested up to: 6.9 < 7.1. The "Tested up to" value in your plugin is not set to the current version of WordPress. This means your plugin will not show up in searches, as we require plugins to be compatible and documented as tested up to the most recent version of WordPress.
📁 phpstan/constants.php (1 error)
📍 Line 🔖 Check 💬 Message
0 missing_direct_file_access_protection PHP file should prevent direct access. Add a check like: if ( ! defined( 'ABSPATH' ) ) exit;

🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check

The plugin header said BSD-0-Clause (linking to BSD-3-Clause), readme.txt said GPL-3, and
composer.json said GPL-2.0. All three now say GPL-2.0-or-later, like the other plugins, and
the plugin ships the GPL-2 LICENSE file they use.
@josephfusco josephfusco removed the Needs Decision Blocked on a maintainer call, not on more work label Oct 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Area] Debug Extensions Issues for the WPGraphQL Debug Extensions plugin Security Work relates to vulnerabilities or hardening [Type] Bug An existing feature is broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant