Repository navigation
Add tests for guarantee ledger gaps - #44
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
保証台帳の Gaps のうち4件にテストを足し、緑になった分を台帳の表へ移した。
build --incrementalが、置き場所・アカウント・本体のコード・[scan.repos]以外の設定の変化で作り直すこと(incremental.md に4行)check_every_hoursの起動のずれの5分(publish.md の既存行にテストを追加)waitsの表示が待っている Issue のページへのリンクであること(plugins.md)「
build --incrementalは Issue の一覧が変わったら作り直す」はテストが赤になった。Issue の一覧が変わっても、リポのページは作り直されず、Issue のページだけが書き直される。テストは入れず、実装の直しを Issue 11(issues/11_incremental-issue-list.md、status: draft)に起こした。約束にはせず、Gaps にも残さない。生成物が 20,000 ファイルを超えたときの
publishの件は、テストが重すぎるため約束しないものとして Gaps から消した。Gaps が空になったので節ごと消した。検証:
nix develop -c pytest -q(95 passed)