Repository navigation
Conversation
`zarr.storage` was replaced at import time by `VerboseModule`, a `types.ModuleType` subclass that only existed to warn about the long-deprecated `zarr.storage.default_compressor` attribute. Serializers that dispatch on the exact type of an object miss that subclass: `cloudpickle` (used by Dask) registers a reduce for `ModuleType`, so any attempt to serialize the module raised `TypeError: cannot pickle 'VerboseModule' object`, which made `zarr.storage.ObjectStore`-backed Dask arrays impossible to send to a cluster. Drop the wrapper as suggested in zarr-developers#4029 and add a regression test. Setting `zarr.storage.default_compressor` no longer warns; `zarr.config` is the supported way to configure `array.v2_default_compressor`.
…ule removal Rename the changelog fragment from the issue number (4029) to the PR number (4505), as changes/README.md requires, and shorten it to the user-visible effect. Add a removal fragment for the dropped `zarr.storage.default_compressor` deprecation warning, as the deprecation policy in docs/contributing.md requires when a deprecated API is finally removed. Replace the comment block in test_storage_module_is_picklable with a docstring, matching the neighboring tests. Assisted-by: ClaudeCode:claude-fable-5-1 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The test only checked that `zarr.storage` is a plain `ModuleType` and that cloudpickle can pickle a plain module. The first guards against re-adding a one-off `__class__` swap; the second tests cloudpickle. Neither justified a new pinned test dependency, so the test, the `cloudpickle` pin in the `test` group, and its `uv.lock` entries go. Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Author
|
closing in favor of #4557 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR follows up on #4505 by updating the changelog entry and removing the test that was added. We don't need to test that the module is pickleable. It's just a regular module now.
Author attestation
TODO
docs/user-guide/*.mdchanges/