Repository navigation
feat(desktop-gpui): redraw the recording modes panel in the onboarding style - #3522
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Member
Author
|
hey @greptileai, please re-review the PR |
Member
Author
|
hey @greptileai, please re-review the PR |
Member
Author
|
hey @greptileai, please re-review the PR |
![capy-ai[bot]](https://avatars.githubusercontent.com/in/1915919?s=60&v=4){kind=small}
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Recording Modes panel in the main window now uses the onboarding tour's look: one hand-drawn doodle card per mode, plus a detail area with the tagline and features of the hovered or current mode.
Long mode names (English, Spanish, Japanese) widen their own card instead of truncating:
flowchart LR open["open_panel(ModeInfo)"] --> stamp["mode_info_opened_at = now"] stamp --> draw["doodles draw in, staggered"] stamp --> timer["timer: MODE_INFO_DRAW_DURATION"] timer --> still["notify: doodles render still"] hover["hover a card"] --> preview["mode_info_preview = Some(mode)"] preview --> detail["detail shows that mode"] click["click a card"] --> set["set_mode + close_panel"]render_mode_info(apps/desktop-gpui/src/main_window.rs:6118) draws three cards with the onboarding doodles (UPLOAD,TRACKS,SNAP), the onboarding palette (onboarding_window::Paper), and 1.5px borders. The current mode gets an accent border. Cards areflex_autowith a no-wrap label, so a long translated name takes a little more width from its neighbours.mode_info_preview(the hovered card) or the effective mode. The effective mode gets a "Current" tag.mode_detailandmode_doodle(apps/desktop-gpui/src/onboarding_window.rs:187,:801).MODESbecomes astaticsomode_detailcan return&'staticreferences.MODE_INFO_DRAW_DURATIONafter the panel opens (main_window.rs:38,:4372), then render still. An open panel stops requesting frames, and reduce motion skips the animation.set_modeand closes the panel. While the editor is recording, the other modes stay dimmed.main.mode.info.*descriptions are no longer read, so they are removed from all seven locales.main.mode.info.currentis added.CAP_GPUI_AUTO_PANEL=modesopens the panel at launch, like the existingdisplay,cameraandrecordingsvalues (main_window.rs:1385).
The PR appears safe to merge; no blocking issues remain.Summary
The PR redraws the recording modes panel with onboarding doodles and shared translated descriptions.
Reviews (4) · Last reviewed commit: "fix(desktop-gpui): let the latest hover ..." · Reviewed by Greptile